Opened 12 years ago

Closed 12 years ago

#4572 closed defect (fixed)

[with patch, positive review] maxima output has misleading precision

Reported by: robertwb Owned by: burcin
Priority: major Milestone: sage-3.2.1
Component: calculus Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Internally, maxima uses floating point numbers internally unless explicitly told to use bigfloats (which we don't, and there's only one global precision in maxima so it will be non-trivial to try and do this consistantly). This patch changes the parsing code to use RDF instead, which is a better reflection of the underlying precision.

In addition, this has the benefit of removing the trailing zeros in calculus expressions involving real numbers (as they didn't really contain any information).

Attachments (3)

4572-maxima-float.patch (5.2 KB) - added by robertwb 12 years ago.
4572-maxima-float-fixes.patch (9.9 KB) - added by robertwb 12 years ago.
4572-maxima-float-fixes-tut.patch (603 bytes) - added by robertwb 12 years ago.
apply to docs repo

Download all attachments as: .zip

Change History (9)

Changed 12 years ago by robertwb

comment:1 Changed 12 years ago by mhansen

  • Summary changed from [with patch, needs review] maxima output has misleading precision to [with patch, positive review] maxima output has misleading precision

Applies and passes tests.

comment:2 Changed 12 years ago by mabshoff

This patch seems to cause a boat load of small and annoying doctest failures:

        sage -t -long devel/sage/sage/rings/polynomial/polynomial_real_mpfr_dense.pyx # 1 doctests failed
        sage -t -long devel/sage/sage/rings/real_rqdf.pyx # 1 doctests failed
        sage -t -long devel/sage/sage/rings/real_double.pyx # 2 doctests failed
        sage -t -long devel/sage/sage/rings/real_mpfr.pyx # 2 doctests failed
        sage -t -long devel/sage/sage/rings/complex_double.pyx # 3 doctests failed
        sage -t -long devel/sage/sage/plot/plot.py # 1 doctests failed
        sage -t -long devel/sage/sage/misc/parser.pyx # 1 doctests failed
        sage -t -long devel/sage/sage/misc/prandom.py # 1 doctests failed
        sage -t -long devel/sage/sage/matrix/tests.py # 1 doctests failed
        sage -t -long devel/sage/sage/interfaces/maxima.py # 3 doctests failed
        sage -t -long devel/sage/sage/functions/special.py # 7 doctests failed
        sage -t -long devel/sage/sage/functions/constants.py # 1 doctests failed
        sage -t -long devel/sage/sage/functions/piecewise.py # 3 doctests failed
        sage -t -long devel/doc/tut/tut.tex # 1 doctests failed

I will make 100% sure this can all be blamed on this patch.

Cheers,

Michael

comment:3 Changed 12 years ago by mabshoff

  • Summary changed from [with patch, positive review] maxima output has misleading precision to [with patch, needs work] maxima output has misleading precision

Yep, someone needs to fix those doctests :)

Cheers,

Michael

Changed 12 years ago by robertwb

Changed 12 years ago by robertwb

apply to docs repo

comment:4 Changed 12 years ago by robertwb

  • Summary changed from [with patch, needs work] maxima output has misleading precision to [with patch, needs review] maxima output has misleading precision

All doctest failures were due to precision printing differences. Apply all attached patches.

comment:5 Changed 12 years ago by mabshoff

  • Summary changed from [with patch, needs review] maxima output has misleading precision to [with patch, positive review] maxima output has misleading precision

Positive review to the doctest fixes, so a cumulative positive review :)

Cheers,

Michae

comment:6 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged both patches in Sage 3.2.1.alpha1

Note: See TracTickets for help on using tickets.