Opened 14 years ago

Closed 13 years ago

#4552 closed defect (fixed)

[with patch, positive review] notebook -- when email system on, registration is broken

Reported by: Timothy Clemans Owned by: Kelly Boothby
Priority: major Milestone: sage-4.1.2
Component: notebook Keywords:
Cc: wjp Merged in: Sage 4.1.2.alpha1
Authors: Timothy Clemans Reviewers: Willem Jan Palenstijn
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Depends on #4551

Attachments (2)

sage-4552.patch (1.2 KB) - added by Timothy Clemans 14 years ago.
trac_4552-notebook_account_email.patch (1.5 KB) - added by wjp 13 years ago.
modified patch without dependency on #4551

Download all attachments as: .zip

Change History (9)

Changed 14 years ago by Timothy Clemans

Attachment: sage-4552.patch added

comment:1 Changed 14 years ago by Timothy Clemans

Summary: notebook -- when email system on, registration is broken[with patch, needs review] notebook -- when email system on, registration is broken

comment:2 Changed 14 years ago by Kelly Boothby

Timothy -- please describe the problem that this is supposed to fix. "Depends on #4551" is insufficient.

comment:3 Changed 14 years ago by Timothy Clemans

If the email config is set to True then registration doesn't work.

Changed 13 years ago by wjp

modified patch without dependency on #4551

comment:4 Changed 13 years ago by wjp

I modified the attached patch to remove the dependency on #4551. (Only apply trac_4552-notebook_account_email.patch)

To elaborate on the problem a little bit: the problem was that the value of the 'email' input box was never read from the form. As a result, when the verification code tries to access it, the server gets a KeyError?.

For what it's worth, I give a positive review to adding 'email' to 'input_boxes', which is how Timothy's patch fixes the problem.

comment:5 Changed 13 years ago by wjp

Cc: wjp added

comment:6 Changed 13 years ago by wjp

Summary: [with patch, needs review] notebook -- when email system on, registration is broken[with patch, positive review] notebook -- when email system on, registration is broken

It turns out the dependency on #4551 was really a dependency on #4135. Now that that has been merged, positive review.

Note to release manager: apply only the _original_ patch (sage-4552.patch)

comment:7 Changed 13 years ago by Minh Van Nguyen

Authors: Timothy Clemans
Merged in: Sage 4.1.2.alpha1
Resolution: fixed
Reviewers: Willem Jan Palenstijn
Status: newclosed

Merged sage-4552.patch.

Note: See TracTickets for help on using tickets.