Opened 14 years ago
Closed 13 years ago
#4551 closed enhancement (fixed)
SageNB: Notebook Settings page
Reported by: | TimothyClemans | Owned by: | boothby |
---|---|---|---|
Priority: | major | Milestone: | sage-4.2 |
Component: | notebook | Keywords: | |
Cc: | wjp, timdumol, was | Merged in: | |
Authors: | Timothy Clemans, Mitesh Patel | Reviewers: | was |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Depends on #4550
Please see the patch descriptions and the comments below for specific dependencies.
Attachments (6)
Change History (15)
comment:1 Changed 14 years ago by
Summary: | notebook -- implement Notebook Settings page with email system on/off setting → [with patch, needs review] notebook -- implement Notebook Settings page with email system on/off setting |
---|
Changed 14 years ago by
Attachment: | sage-4551.patch added |
---|
Changed 14 years ago by
Attachment: | sage-4551_2.patch added |
---|
comment:2 Changed 14 years ago by
comment:3 Changed 13 years ago by
Cc: | wjp added |
---|
Changed 13 years ago by
Attachment: | trac_4551.patch added |
---|
first two patches folded into one, rebased on 4.1.2.alpha0 + #4550
Changed 13 years ago by
Attachment: | trac_4550+4551-settings_page.patch added |
---|
comment:4 Changed 13 years ago by
I'm working on adding other server settings to the "Notebook Settings" page.
Changed 13 years ago by
Attachment: | trac_4551-settings_page_v2.patch added |
---|
comment:5 Changed 13 years ago by
The new version, based on #6983's revision 72, #7110, and #7158, can display and update all server settings.
With some extra work, we can do the same for user settings, including custom key bindings, for example.
Feel free to suggest changes. Potential "To do" list items:
- Use templates.
- Check for errors.
- "Reset to defaults" option.
- "Revert to earlier configuration" option. This should be straightforward to implement, if we use a versioning system for the
.conf
files. - Combine the
defaults
anddefaults_descriptions
dictionaries. - Remove unused settings.
- Use a color picker for color settings.
- User settings, including key bindings, CSS, etc.
comment:6 Changed 13 years ago by
Authors: | → Timothy Clemans, Mitesh Patel |
---|---|
Cc: | timdumol was added |
comment:7 Changed 13 years ago by
Changed 13 years ago by
Attachment: | trac_4551-settings_page_v3.patch added |
---|
comment:8 Changed 13 years ago by
Description: | modified (diff) |
---|---|
Summary: | [with patch, needs review] notebook -- implement Notebook Settings page with email system on/off setting → SageNB: Notebook Settings page |
Patch v3:
- Uses Farbtastic for color settings.
- Updates the
descriptions_defaults
dictionary. - Adds a
T_LIST
type. - Changes
'email'
's type back toT_BOOL
.
Remarks:
- It would be simpler (and more consistent?) to use
[]
instead ofNone
for an emptyserver_poll
setting. - Install the more compact jPicker. Use it for
interact
s, too?
comment:9 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Reviewers: | → was |
Status: | needs_review → closed |
Looks AWESOME! Strong positive review (despite some missing doctests, which is OK at this stage since this isn't part of the Sage library). Very very good. This adds a huge amount of much needed functionality!
Depends on #4135