Opened 14 years ago

Closed 13 years ago

#4551 closed enhancement (fixed)

SageNB: Notebook Settings page

Reported by: TimothyClemans Owned by: boothby
Priority: major Milestone: sage-4.2
Component: notebook Keywords:
Cc: wjp, timdumol, was Merged in:
Authors: Timothy Clemans, Mitesh Patel Reviewers: was
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mpatel)

Depends on #4550

Please see the patch descriptions and the comments below for specific dependencies.

Attachments (6)

sage-4551.patch​ (4.6 KB) - added by TimothyClemans 14 years ago.
sage-4551_2.patch​ (2.7 KB) - added by TimothyClemans 14 years ago.
trac_4551.patch​ (4.8 KB) - added by ddrake 13 years ago.
first two patches folded into one, rebased on 4.1.2.alpha0 + #4550
trac_4550+4551-settings_page.patch​ (11.8 KB) - added by mpatel 13 years ago.
Rebased for sagenb #6983 + #7110 (including #5447) + #7158 + #4550.
trac_4551-settings_page_v2.patch​ (20.7 KB) - added by mpatel 13 years ago.
SageNB: settings page for all server options. Depends on #7110, #7158. Apply only this patch.
trac_4551-settings_page_v3.patch​ (21.5 KB) - added by mpatel 13 years ago.
Now uses Farbtastic as a color chooser. Rebased against #7196 + #7158 v2. Apply only this patch.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 14 years ago by TimothyClemans

Summary: notebook -- implement Notebook Settings page with email system on/off setting → [with patch, needs review] notebook -- implement Notebook Settings page with email system on/off setting

Changed 14 years ago by TimothyClemans

Attachment: sage-4551.patch​ added

Changed 14 years ago by TimothyClemans

Attachment: sage-4551_2.patch​ added

comment:2 Changed 14 years ago by TimothyClemans

Depends on #4135

comment:3 Changed 13 years ago by wjp

Cc: wjp added

Changed 13 years ago by ddrake

Attachment: trac_4551.patch​ added

first two patches folded into one, rebased on 4.1.2.alpha0 + #4550

Changed 13 years ago by mpatel

Attachment: trac_4550+4551-settings_page.patch​ added

Rebased for sagenb #6983 + #7110 (including #5447) + #7158 + #4550.

comment:4 Changed 13 years ago by mpatel

I'm working on adding other server settings to the "Notebook Settings" page.

Changed 13 years ago by mpatel

Attachment: trac_4551-settings_page_v2.patch​ added

SageNB: settings page for all server options. Depends on #7110, #7158. Apply only this patch.

comment:5 Changed 13 years ago by mpatel

The new version​, based on #6983's revision 72, #7110, and #7158, can display and update all server settings.

With some extra work, we can do the same for user settings, including custom key bindings, for example.

Feel free to suggest changes. Potential "To do" list items:

  • Use templates.
  • Check for errors.
  • "Reset to defaults" option.
  • "Revert to earlier configuration" option. This should be straightforward to implement, if we use a versioning system for the .conf files.
  • Combine the defaults and defaults_descriptions dictionaries.
  • Remove unused settings.
  • Use a color picker for color settings.
  • User settings, including key bindings, CSS, etc.

comment:6 Changed 13 years ago by mpatel

Authors: → Timothy Clemans, Mitesh Patel
Cc: timdumol was added

comment:7 Changed 13 years ago by mpatel

Reminder: Rebase against the outcomes of #7196, #7158, if the new changes are worthwhile.

Changed 13 years ago by mpatel

Attachment: trac_4551-settings_page_v3.patch​ added

Now uses Farbtastic as a color chooser. Rebased against #7196 + #7158 v2. Apply only this patch.

comment:8 Changed 13 years ago by mpatel

Description: modified (diff)
Summary: [with patch, needs review] notebook -- implement Notebook Settings page with email system on/off setting → SageNB: Notebook Settings page

Patch v3:

  • Uses ​Farbtastic for color settings.
  • Updates the descriptions_defaults dictionary.
  • Adds a T_LIST type.
  • Changes 'email''s type back to T_BOOL.

Remarks:

  • It would be simpler (and more consistent?) to use [] instead of None for an empty server_poll setting.
  • Install the more compact ​jPicker. Use it for interacts, too?

comment:9 Changed 13 years ago by was

Resolution: → fixed
Reviewers: → was
Status: needs_review → closed

Looks AWESOME! Strong positive review (despite some missing doctests, which is OK at this stage since this isn't part of the Sage library). Very very good. This adds a huge amount of much needed functionality!

Note: See TracTickets for help on using tickets.