Opened 14 years ago

Closed 14 years ago

#4531 closed defect (fixed)

[with patch, positive review] Sage 3.2.rc1: automorphism_group() doctest failure on 32 bit in sage/combinat/species/library.py

Reported by: mabshoff Owned by: was
Priority: blocker Milestone: sage-3.2
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

sage -t  devel/sage/sage/combinat/species/library.py 
********************************************************************** 
File "/home/john/sage-3.2.rc1/devel/sage/sage/combinat/species/library.py", 
line 86: 
    sage: a.automorphism_group() 
Expected: 
    Permutation Group with generators [(), ()] 
Got: 
    Permutation Group with generators [()] 
********************************************************************** 

Attachments (3)

sage-4531.patch (20.1 KB) - added by was 14 years ago.
doc-4531.patch (923 bytes) - added by was 14 years ago.
sage-4531-part2.patch (739 bytes) - added by was 14 years ago.
trivial followup

Download all attachments as: .zip

Change History (9)

comment:1 Changed 14 years ago by GeorgSWeber

That seems to be a problem of how Sage displays/prints permutation groups. Internally, everything seems fine. I just produced such a group and I get:

sage: B = species.BinaryTreeSpecies()
sage: a = B.structures([1,2,3,4,5]).random_element(); a
(1*5)*((2*3)*4)
sage: grp = a.automorphism_group()
sage: grp
Permutation Group with generators [(), ()]
sage: grp.list()
[()]

The latter two lines are pretty inconsistent.

comment:2 Changed 14 years ago by mabshoff

Mike Hansen mentioned in IRC that this is the expected output and will post a patch to fix this in the morning.

Cheers,

Michael

comment:3 Changed 14 years ago by GeorgSWeber

OK. Thanks for this info!

comment:4 Changed 14 years ago by was

  • Owner changed from mhansen to was

I am fixing this by changing permutation groups to make their gens be canonicalized by default (meaning they are sorted and duplicates are removed). This is *much* more in the spirit of Sage. There is still the option to have the generators be exactly what is input (duplicates and all).

Changed 14 years ago by was

Changed 14 years ago by was

Changed 14 years ago by was

trivial followup

comment:5 Changed 14 years ago by mabshoff

  • Summary changed from Sage 3.2.rc1: automorphism_group() doctest failure on 32 bit in sage/combinat/species/library.py to [with patch, positive review] Sage 3.2.rc1: automorphism_group() doctest failure on 32 bit in sage/combinat/species/library.py

mhansen gave this patch a positive review assuming the doctests pass. Since they do I am changing the subject.

Cheers,

Michael

comment:6 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged all three patches in Sage 3.2.rc2

Note: See TracTickets for help on using tickets.