Opened 14 years ago
Closed 14 years ago
#4528 closed defect (fixed)
[with patch, with positive review] Implement Krull dimension for orders in number fields
Reported by: | cremona | Owned by: | was |
---|---|---|---|
Priority: | minor | Milestone: | sage-3.2.1 |
Component: | number theory | Keywords: | number fields, orders |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This is a triviality, but I noticed it while doing something else. All order in number fields have Krull dimension 1, but this was not implemented -- not even for the maximal order. Now it is.
Patch based on 3.2.rc1, touches rings/ring.pyx and rings/number_field/order.py
Attachments (1)
Change History (3)
Changed 14 years ago by
comment:1 Changed 14 years ago by
- Summary changed from [with patch, needs review] Implement Krull dimension for orders in number fields to [with patch, with positive review] Implement Krull dimension for orders in number fields
comment:2 Changed 14 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.2.1.alpha0
Note: See
TracTickets for help on using
tickets.
This looks good.
As a really trivial issue, someone should add a
.
at the end of line 754 ofring.pyx
. It didn't seem worth another patch.