Opened 12 years ago

Closed 7 years ago

#4474 closed defect (duplicate)

A hack in preparsing files is dangerous/confusing

Reported by: was Owned by: cwitty
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: misc Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

There is a dangerous hack in preparser.py. Given input file:

load a.sage
load b.py

Then b.py will be loaded while the file is being *parsed*, and *before* a.sage is loaded. That would be very confusing. See the related #4473 and apply that patch before working on this.

Change History (5)

comment:1 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:2 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:3 Changed 7 years ago by aapitzsch

  • Milestone changed from sage-6.2 to sage-duplicate/invalid/wontfix
  • Report Upstream set to N/A
  • Status changed from new to needs_review

The hack has been removed in #7514.

comment:4 Changed 7 years ago by ncohen

  • Status changed from needs_review to positive_review

You must set it to positive_review in this case.

comment:5 Changed 7 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.