Opened 14 years ago

Closed 14 years ago

Last modified 7 years ago

#4395 closed defect (fixed)

[with patch; positive review] Sage 3.1.4: magma related optional doctest failure in sage/rings/quotient_ring.py

Reported by: Michael Abshoff Owned by: William Stein
Priority: major Milestone: sage-3.2
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Frédéric Chapoton)

sage -t -long -optional devel/sage/sage/rings/quotient_ring.py
**********************************************************************
File "/home/mabshoff/build-3.2.a1/sage-3.2.alpha1-iras/tmp/quotient_ring.py", line 647:
    sage: Q._magma_() # optional requires Magma
Expected:
    Affine Algebra of rank 2 over GF(2)
    Graded Reverse Lexicographical Order
    Variables: x, y
    Quotient relations:
    [
    x^2 + x,
    y^2 + y
    ]
Got:
    Affine Algebra of rank 2 over GF(2)
    Graded Reverse Lexicographical Order
    Variables: x, y
    Quotient relations:
    [
    0,
    0
    ]
**********************************************************************
1 items had failures:
   1 of   5 in __main__.example_23
***Test Failed*** 1 failures.
For whitespace errors, see the file /home/mabshoff/build-3.2.a1/sage-3.2.alpha1-iras/tmp/.doctest_quotient_ring.py
 [5.4 s]
exit code: 1024

Attachments (1)

sage-4395.patch (3.3 KB) - added by William Stein 14 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 14 years ago by William Stein

Summary: Sage 3.1.4: magma related optional doctest failure in sage/rings/quotient_ring.py[with patch; needs review] Sage 3.1.4: magma related optional doctest failure in sage/rings/quotient_ring.py

Apply this after #4394

comment:2 Changed 14 years ago by Michael Abshoff

Where is the patch?

Cheers,

Michael

comment:3 Changed 14 years ago by Michael Abshoff

This patch (one it is here :)) also likely fixes the following problem:

sage -t -long -optional devel/sage/sage/rings/polynomial/pbori.pyx
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.1.3.final/tmp/pbori.py", line 988:
    sage: B._magma_() # optional requires magma
Expected:
    Affine Algebra of rank 3 over GF(2)
    Lexicographical Order
    Variables: x, y, z
    Quotient relations:
    [
    x^2 + x,
    y^2 + y,
    z^2 + z
    ]
Got:
    Affine Algebra of rank 3 over GF(2)
    Lexicographical Order
    Variables: x, y, z
    Quotient relations:
    [
    0,
    0,
    0
    ]
**********************************************************************
File "/scratch/mabshoff/release-cycle/sage-3.1.3.final/tmp/pbori.py", line 1024:
    sage: B._magma_() # optional requires magma, indirect doctest
Expected:
    Affine Algebra of rank 3 over GF(2)
    Lexicographical Order
    Variables: x, y, z
    Quotient relations:
    [
    x^2 + x,
    y^2 + y,
    z^2 + z
    ]
Got:
    Affine Algebra of rank 3 over GF(2)
    Lexicographical Order
    Variables: x, y, z
    Quotient relations:
    [
    0,
    0,
    0
    ]
**********************************************************************

Changed 14 years ago by William Stein

Attachment: sage-4395.patch added

comment:4 Changed 14 years ago by Michael Abshoff

Milestone: sage-3.2.1sage-3.2
Summary: [with patch; needs review] Sage 3.1.4: magma related optional doctest failure in sage/rings/quotient_ring.py[with patch; positive review] Sage 3.1.4: magma related optional doctest failure in sage/rings/quotient_ring.py

Positive review. It fixes the original problem reported, but not as I suspected the issue in

devel/sage/sage/rings/polynomial/pbori.pyx

That issue is now #4482.

Cheers,

Michael

comment:5 Changed 14 years ago by Michael Abshoff

Resolution: fixed
Status: newclosed

Merged in Sage 3.2.rc0

comment:6 Changed 7 years ago by Frédéric Chapoton

Description: modified (diff)
Report Upstream: N/A
Note: See TracTickets for help on using tickets.