Opened 14 years ago

Closed 14 years ago

#4394 closed defect (fixed)

[with patch; positive review] Sage 3.1.4: magma related optional doctest failure in sage/rings/polynomial/polynomial_element.pyx

Reported by: Michael Abshoff Owned by: William Stein
Priority: major Milestone: sage-3.2
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description 

mabshoff@iras:~/build-3.2.a1/sage-3.2.alpha1-iras> ./sage -t -long -optional devel/sage/sage/rings/polynomial/polynomial_element.pyx
sage -t -long -optional devel/sage/sage/rings/polynomial/polynomial_element.pyx
**********************************************************************
File "/home/mabshoff/build-3.2.a1/sage-3.2.alpha1-iras/tmp/polynomial_element.py", line 2833:
    sage: g = magma(f); g              # optional -- requires Magma
Expected:
    y^3 - 17*y + 5
Got:
    $.1^3 - 17*$.1 + 5
**********************************************************************
1 items had failures:

Attachments (1)

sage-4394.patch​ (962 bytes) - added by William Stein 14 years ago.

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by William Stein

Attachment: sage-4394.patch​ added

comment:1 Changed 14 years ago by William Stein

Summary: Sage 3.1.4: magma related optional doctest failure in sage/rings/polynomial/polynomial_element.pyx → [with patch; needs review] Sage 3.1.4: magma related optional doctest failure in sage/rings/polynomial/polynomial_element.pyx

comment:2 Changed 14 years ago by Michael Abshoff

Summary: [with patch; needs review] Sage 3.1.4: magma related optional doctest failure in sage/rings/polynomial/polynomial_element.pyx → [with patch; positive review] Sage 3.1.4: magma related optional doctest failure in sage/rings/polynomial/polynomial_element.pyx

Positive review. The patch makes the doctests pass: 

mabshoff@sage:/scratch/mabshoff/release-cycle/sage-3.1.3.final$ 
./sage -t -long -optional devel/sage/sage/rings/polynomial/polynomial_element.pyx
sage -t -long -optional devel/sage/sage/rings/polynomial/polynomial_element.pyx
	 [11.4 s]
 
----------------------------------------------------------------------

Cheers,

Michael

comment:3 Changed 14 years ago by Michael Abshoff

Resolution: → fixed
Status: new → closed

Merged in Sage 3.2.alpha2

Note: See TracTickets for help on using tickets.