Opened 13 years ago

Closed 12 years ago

#4363 closed defect (fixed)

[with patch, positive review] Do not automatically evaluate interact cells in notebook

Reported by: kcrisman Owned by: mhansen
Priority: major Milestone: sage-3.3
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Current behavior is that @interact cells automatically evaluate upon opening a worksheet. This can cause problems if (for instance) the cell depends on other cells which are not automatically evaluated, and also can take a long time if there are lots of them.

Since other cells do not auto-evaluate, and since this functionality still is easily available by putting #auto in the cell, this ticket calls for the current behavior to be changed.

Attachments (1)

trac_4363.patch (843 bytes) - added by mhansen 12 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by jason

I second that this should be changed.

comment:2 Changed 13 years ago by mhansen

  • Owner changed from boothby to mhansen
  • Status changed from new to assigned
  • Summary changed from Do not automatically evaluate interact cells in notebook to [with patch, needs review] Do not automatically evaluate interact cells in notebook

I've also added this as a test case to the notebook test suite.

comment:3 Changed 13 years ago by was

I think to solve this trac ticket, it is necessary that:

  1. Output of interact cells should be completely empty when a worksheet is open.
  1. @interact needs to work with #auto (or %auto?) because I have a project with a student that involves making a bunch of interacts that are all %hideall'd, so one sees *only* the controls.

comment:4 Changed 13 years ago by was

Just to emphasize, the patch above mysteriously doesn't work with #auto...

comment:5 Changed 13 years ago by mhansen

  • Summary changed from [with patch, needs review] Do not automatically evaluate interact cells in notebook to [with patch, needs woork] Do not automatically evaluate interact cells in notebook

comment:6 Changed 13 years ago by mhansen

  • Summary changed from [with patch, needs woork] Do not automatically evaluate interact cells in notebook to [with patch, needs work] Do not automatically evaluate interact cells in notebook

Changed 12 years ago by mhansen

comment:7 Changed 12 years ago by mhansen

  • Summary changed from [with patch, needs work] Do not automatically evaluate interact cells in notebook to [with patch, needs review] Do not automatically evaluate interact cells in notebook

I've posted a patch which does not enqueue interact cells at startup and deletes their output so that users don't think that they're running.

I've also made a ticket to fix the auto-evaluation at http://trac.sagemath.org/sage_trac/ticket/5020 . I think this is a separate issue, and I'm looking into it.

comment:8 Changed 12 years ago by mhampton

  • Priority changed from minor to major
  • Summary changed from [with patch, needs review] Do not automatically evaluate interact cells in notebook to [with patch, positive review] Do not automatically evaluate interact cells in notebook

This seems to solve the problem, and the auto-launch problem of #4947. My setup seems to have some issues with #auto cells, so I can't test the compatibility of this patch with that, but that is addressed in other ways by #5020.

comment:9 Changed 12 years ago by mabshoff

  • Milestone changed from sage-3.4.1 to sage-3.3
  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.3.alpha0

Note: See TracTickets for help on using tickets.