Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#4362 closed defect (fixed)

[with patch, positive review] Bug fixes in tableaux latex output

Reported by: bump Owned by: mhansen
Priority: major Milestone: sage-3.2
Component: combinatorics Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The latex output of tableaux is a broke, which affects the latex output in CrystalOfTableaux?. Patches that fix this were attached to #4355 but I should have created a new ticket for these since that ticket really proposes something different.

See #4355 for the patches.

See http://groups.google.com/group/sage-combinat-devel/browse_thread/thread/3fff0cbc6b44b483?hl=en for discussion. But in a nutshell try

latex(Tableau([[1,2,3],[2,2],[3,4],[4]])) 
latex(Tableau([[1,1,2,3,4],[2,2,2],[3]])) 
latex(Tableau([[1],[2],[3],[4]])) 
latex(Tableau([[1,2,3,4]])) 
latex(Tableau([[1,2,3,4],[5,6,7,8]])) 
latex(Tableau([[1,2,3,4],[5,6,7,8],[9]])) 
latex(Tableau([[1,2,],[5,6],[7,9]])) 
latex(Tableau([[1,2,],[5,6],[7,9],[9]])) 
latex(Tableau([[1,2,3,4,5,],[6]])) 
latex(Tableau([[1,2,3,4,5,],[6],[7],[8],[9]])) 

etc or

CrystalOfTableaux("A2",shape=[3,1]).latex_file("/home/bump/tmp/test.tex")

to see the defect.

Attachments (3)

tableaux_output.patch (2.5 KB) - added by mabshoff 13 years ago.
First of Dan's patches from #4355
tableaux_output1.patch (4.1 KB) - added by mabshoff 13 years ago.
Second of Dan's patches from #4355
tableaux_output2.patch (3.3 KB) - added by bump 13 years ago.

Download all attachments as: .zip

Change History (9)

Changed 13 years ago by mabshoff

First of Dan's patches from #4355

Changed 13 years ago by mabshoff

Second of Dan's patches from #4355

comment:1 Changed 13 years ago by mabshoff

  • Milestone set to sage-3.2
  • Summary changed from Bug fixes in tableaux latex output [with patches at #4355. Needs review.] to Bug fixes in tableaux latex output [with patche, needs review]

Dan,

I have moved the patches from #4355 over here and will delete them on the other ticket. Having patches from another ticket applied via this ticket will only make things more complicated than they need to be.

Cheers,

Michael

comment:2 Changed 13 years ago by mabshoff

  • Summary changed from Bug fixes in tableaux latex output [with patche, needs review] to [with patch, needs review] Bug fixes in tableaux latex output

comment:3 Changed 13 years ago by mhansen

  • Summary changed from [with patch, needs review] Bug fixes in tableaux latex output to [with patch, positive review] Bug fixes in tableaux latex output

I tested this out on all the examples, and it looks good to me.

Changed 13 years ago by bump

comment:4 Changed 13 years ago by bump

Nicolas suggested that the tests should reflect the problem. As it turns out the existing tests all have square tableaux (in tensor_product.py, tableau.py and output.py) which is a rare case that is not broke for the original code.

http://groups.google.com/group/sage-combinat-devel/msg/cd0de81b0e2f0ae5?hl=en

Nicolas posted this before Mike reviewed the patch. In view of Nicolas' comment I'm uploading a third patch tableaux_output2.patch that makes the tests non-rectangular tableaux for which the original code was broke.

comment:5 Changed 13 years ago by mabshoff

  • Milestone changed from sage-3.2.1 to sage-3.2
  • Resolution set to fixed
  • Status changed from new to closed

Merged all three patches in Sage 3.2.rc0.

Dan: Please make sure that you post patches and not diffs. I did apply and commit the patches above in your name, so no need to update anything here.

Cheers,

Michael

comment:6 Changed 12 years ago by nthiery

  • Cc sage-combinat added
Note: See TracTickets for help on using tickets.