Opened 14 years ago

Closed 14 years ago

#4359 closed defect (fixed)

[with patch, positive review] Huge number of small fixes to modular forms code

Reported by: Craig Citro Owned by: Craig Citro
Priority: major Milestone: sage-3.2
Component: modular forms Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This is just a big bundle of fixes to the modular forms code that I had piled up.

Attachments (2)

trac-4359.patch​ (20.3 KB) - added by Craig Citro 14 years ago.
trac-4359-2.patch​ (870 bytes) - added by Craig Citro 14 years ago.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by Craig Citro

Attachment: trac-4359.patch​ added

comment:1 Changed 14 years ago by Alex Ghitza

Looks good. I have some questions about _ensure_is_compatible() in modform/element.py

  1. I guess I don't quite know what the function is meant to be used for; the docstring says "compatible for arithmetic and comparison operations". I assume arithmetic here means addition or subtraction?
  1. With the patch, two forms of the same weight but different groups of the same level are deemed compatible. For instance, if f is on Gamma0(11) and g is on Gamma1(11), or if f and g are on Gamma1(17) but with different Dirichlet characters. Is this the desired behaviour?

Changed 14 years ago by Craig Citro

Attachment: trac-4359-2.patch​ added

comment:2 Changed 14 years ago by Craig Citro

Status: new → assigned

Ah, good point. I added a patch that changes it to test that they have the same ambient space, which is what the docstring claims.

comment:3 Changed 14 years ago by Alex Ghitza

Summary: [with patch, needs review] Huge number of small fixes to modular forms code → [with patch, positive review] Huge number of small fixes to modular forms code

OK, I'm happy.

comment:4 Changed 14 years ago by Michael Abshoff

Resolution: → fixed
Status: assigned → closed

Merged both patches in Sage 3.2.alpha1

Note: See TracTickets for help on using tickets.