Opened 14 years ago
Closed 14 years ago
#4359 closed defect (fixed)
[with patch, positive review] Huge number of small fixes to modular forms code
Reported by: | Craig Citro | Owned by: | Craig Citro |
---|---|---|---|
Priority: | major | Milestone: | sage-3.2 |
Component: | modular forms | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This is just a big bundle of fixes to the modular forms code that I had piled up.
Attachments (2)
Change History (6)
Changed 14 years ago by
Attachment: | trac-4359.patch added |
---|
comment:1 Changed 14 years ago by
Changed 14 years ago by
Attachment: | trac-4359-2.patch added |
---|
comment:2 Changed 14 years ago by
Status: | new → assigned |
---|
Ah, good point. I added a patch that changes it to test that they have the same ambient space, which is what the docstring claims.
comment:3 Changed 14 years ago by
Summary: | [with patch, needs review] Huge number of small fixes to modular forms code → [with patch, positive review] Huge number of small fixes to modular forms code |
---|
OK, I'm happy.
comment:4 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Merged both patches in Sage 3.2.alpha1
Note: See
TracTickets for help on using
tickets.
Looks good. I have some questions about
_ensure_is_compatible()
in modform/element.py