Opened 12 years ago

Closed 12 years ago

#4324 closed defect (fixed)

[with patch, positive review] fix storage of GBs for PolyBoRi

Reported by: malb Owned by: tbd
Priority: critical Milestone: sage-3.2
Component: algebra Keywords:
Cc: PolyBoRi Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The current code prevents certain GB calculations to finish because it throws a ValueError? just before the GB is returned (quit annoying).

Attachments (1)

pbori_bugfix.patch​ (1.0 KB) - added by malb 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by malb

comment:1 Changed 12 years ago by PolyBoRi

  • Summary changed from [with patch, needs review] fix storage of GBs for PolyBoRi to [with patch, positive review] fix storage of GBs for PolyBoRi

the patch is okay. Note, that the bug can only occur, when a system is passed, which is not a minimal GB. However, that's possible.

In the future version PolyBoRi? 0.6 pure reduction can be implemented more efficiently without handling sets. However, you will need a different workaround there 

r=ReductionStrategy()
if not p.lead() in r.leading_terms:
  r.add_generator(p)

comment:2 Changed 12 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.2.alpha1

Note: See TracTickets for help on using tickets.