Opened 13 years ago

Closed 13 years ago

#4308 closed enhancement (fixed)

[with spkg, positive review] make mpc an optional spkg

Reported by: thevenyp Owned by: mabshoff
Priority: major Milestone: sage-3.2.1
Component: packages: optional Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

I am planning to add arbitrary precision complex numbers using the MPC library http://www.multiprecision.org/mpc/.

Here is a sage package based http://www.loria.fr/~thevenyp/mpc-0.5.spkg

Change History (9)

comment:1 Changed 13 years ago by mabshoff

  • Milestone set to sage-3.2
  • Summary changed from mpc spackage to [with spkg, needs review] make mpc an optional spkg

I will review the spkg later on today.

Cheers,

Michael

comment:2 Changed 13 years ago by robertwb

Do we have any sage interface code to go with this yet? I know some was produced at Sage days 10.

Then these extensions should be added based in whether or not this package is installed sage.misc.package.is_package_installed().

comment:3 Changed 13 years ago by mabshoff

Bindings are being written. The spkg should become optional so it is easily buildable from any Sage install. Once/If? mpc is standard the mpc.spkg would also become standard.

Cheers,

Michael

comment:4 Changed 13 years ago by AlexGhitza

See #4446 for a patch implementing a partial interface (still work in progress).

comment:5 Changed 13 years ago by was

  • Summary changed from [with spkg, needs review] make mpc an optional spkg to [with spkg, needs work] make mpc an optional spkg

REFEREE REPORT:

  1. There is no .hg repository in the spkg. You need to
    $cd mpc-0.5
    $ hg init
    $ hg add spkg-install spkg-check SPKG.txt
    
  1. The SPKG.txt doesn't list anybody or any contact info under "package maintainer".
  1. The SPKG.txt has an empty changelog. This should at least list exactly which version of upstream is in the src subdirectory. Typically when refereeing a patch, I like to verify that src/ contains the claimed upstream exactly, since I don't want some virus crap sneaking in.
  1. Speaking of crap, the src/src/ subdirectory is full of .o pre-compiled binary object files. These need to all be deleted.
    teragon-2:src wstein$ pwd
    /Users/wstein/tmp/mpc-0.5/src/src
    teragon-2:src wstein$ ls -1 *.o |wc -l
          57
    

comment:6 Changed 13 years ago by thevenyp

Thanks for your review, the spkg has been changed accordingly.

Regards,

Philippe

comment:7 Changed 13 years ago by AlexGhitza

  • Summary changed from [with spkg, needs work] make mpc an optional spkg to [with spkg, needs review] make mpc an optional spkg

comment:8 Changed 13 years ago by mabshoff

  • Summary changed from [with spkg, needs review] make mpc an optional spkg to [with spkg, positive review] make mpc an optional spkg

Hi Philippe,

I have reviewed your updated spkg. A couple comments:

  • Everything looks good, but some minor details I fixed
  • Checked in the changes you added to the repo in your name
  • added a .hgignore and added some small cleanups to spkg-install

I also deleted the attached spkg since large files should not be attached to trac, but linked from some webspace.

The updated spkg can be found at

http://sage.math.washington.edu/home/mabshoff/release-cycles-3.2.1/rc1/mpc-0.5.p0.spkg

In case you improve/update the mpc.spkg please use that one as a base.

Summary: positive review.

Cheers,

Michael

comment:9 Changed 13 years ago by mabshoff

  • Milestone changed from sage-3.2.2 to sage-3.2.1
  • Resolution set to fixed
  • Status changed from new to closed

Uploaded to the optional spkg repo.

Cheers,

Michael

Note: See TracTickets for help on using tickets.