Opened 13 years ago

Closed 13 years ago

#4307 closed defect (fixed)

[with patch, with positive review] bad error message in SupersingularModule constructor

Reported by: was Owned by: craigcitro
Priority: minor Milestone: sage-3.2
Component: modular forms Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

sage: SupersingularModule(15)
Traceback (most recent call last):
...
ValueError: order of finite field must be a prime power

The error message should say something like:

NotImplementedError: supersingular module of non-prime level not yet implemented

Attachments (1)

trac4307-ssmod_init.patch (2.4 KB) - added by AlexGhitza 13 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by was

  • Priority changed from major to minor

comment:2 Changed 13 years ago by AlexGhitza

  • Summary changed from bad error message in SupersingularModule constructor to [with patch, needs review] bad error message in SupersingularModule constructor

Having looked at the code in ssmod.py, it seems to me that any nontrivial functionality is only implemented for level 1 at the moment. Two things that I tried: dimension() and hecke_matrix().

The attached patch raises ValueErrors if the characteristic is not prime or if the level is not coprime to the characteristic, and a NotImplementedError if the level is > 1.

Extending the functionality in ssmod.py to general levels is right up my alley, so I'll look into doing it in the near future. The code could also use more documentation and tests.

comment:3 Changed 13 years ago by mabshoff

Alex,

please add doctests that show the new behavior to the not yet existing class SupersingularModule?(hecke.HeckeModule_free_module) docstring.

Cheers,

Michael

Changed 13 years ago by AlexGhitza

comment:4 Changed 13 years ago by AlexGhitza

Yes. Done, and replaced the patch.

comment:5 Changed 13 years ago by craigcitro

  • Summary changed from [with patch, needs review] bad error message in SupersingularModule constructor to [with patch, with positive review] bad error message in SupersingularModule constructor

Looks good.

comment:6 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.2.alpha1

Note: See TracTickets for help on using tickets.