Opened 13 years ago

Closed 11 years ago

Last modified 11 years ago

#4305 closed defect (duplicate)

move finite fields into their own directory

Reported by: robertwb Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This is in anticipation of much re-factoring and refinement.

Attachments (3)

4305-move-finite-field.patch (65.7 KB) - added by robertwb 13 years ago.
4305-ff-docs.patch (1.4 KB) - added by robertwb 13 years ago.
apply to docs repo
trac_4305_review.patch (3.0 KB) - added by mabshoff 13 years ago.

Download all attachments as: .zip

Change History (14)

Changed 13 years ago by robertwb

Changed 13 years ago by robertwb

apply to docs repo

comment:1 Changed 13 years ago by mabshoff

  • Summary changed from [with patch, needs review] move finite fields into their own directory to [with patch, positive review] move finite fields into their own directory

Looks good to me - damn the torpedoes :)

Cheers,

Michael

comment:2 Changed 13 years ago by mabshoff

  • Milestone changed from sage-3.1.4 to sage-3.2
  • Summary changed from [with patch, positive review] move finite fields into their own directory to [with patch, needs work] move finite fields into their own directory

Due to trouble when building the tree with the patch applied on sage.math, i.e. finite_field_givaro not being found, this patch unfortunately needs work :(

I will attach a reviewer patch shortly once I have proper net again.

Cheers,

Michael

Changed 13 years ago by mabshoff

comment:3 Changed 13 years ago by mabshoff

Robert,

is anything going on here? I am not sure how much happened to the finite fields since SD 10, but that patch here certainly has gone stale. Should you plan to work on this in the short term please ping me so we can coordinate the big move. Otherwise we should delete the patches and wait until someone tackles this again.

Cheers,

Michael

comment:4 follow-up: Changed 13 years ago by robertwb

  • Milestone changed from sage-3.2.2 to sage-3.3

I'm hoping to have a little time to look into this over the break. Don't delete the patches just yet.

comment:5 in reply to: ↑ 4 Changed 13 years ago by mabshoff

Replying to robertwb:

I'm hoping to have a little time to look into this over the break. Don't delete the patches just yet.

Ok, I just think that a lot of this patch needs to be rebased, so it might be a good idea to start over, but we will see. One aspect that puzzles me to this day is that we never got it to work on any other system but your own.

One issue that likely will need addressing is pickling issues.

Cheers,

Michael

comment:6 Changed 12 years ago by AlexGhitza

  • Summary changed from [with patch, needs work] move finite fields into their own directory to move finite fields into their own directory

comment:7 Changed 12 years ago by ylchapuy

  • Report Upstream set to N/A

Should be closed because of #8218 I guess.

comment:8 Changed 11 years ago by davidloeffler

  • Status changed from needs_work to needs_review
  • Summary changed from move finite fields into their own directory to [fixed by #8218] move finite fields into their own directory

I concur. I'm setting this to "positive review" to bring it to the attention of the release manager who has the authority to close it.

* Please close this ticket without applying any of the patches! *

comment:9 Changed 11 years ago by davidloeffler

  • Status changed from needs_review to positive_review

comment:10 Changed 11 years ago by mpatel

  • Milestone changed from sage-4.5.2 to sage-duplicate/invalid/wontfix
  • Resolution set to duplicate
  • Status changed from positive_review to closed

I'm resolving this ticket as a "duplicate."

comment:11 Changed 11 years ago by mvngu

  • Summary changed from [fixed by #8218] move finite fields into their own directory to move finite fields into their own directory
Note: See TracTickets for help on using tickets.