Opened 14 years ago

Closed 14 years ago

#4262 closed defect (fixed)

[with patch; positive review] Elliptic curve a_invariants command returns a list reference (BAD!!)

Reported by: William Stein Owned by: William Stein
Priority: major Milestone: sage-3.1.3
Component: number theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This sucks:

sage: E = EllipticCurve([1,0,0,0,1])
sage: E.a_invariants()[0] = 100000000
sage: E
Elliptic Curve defined by y^2 + 100000000*x*y  = x^3 +1 over Rational Field

Attachments (1)

sage-4262.patch (1.2 KB) - added by William Stein 14 years ago.

Download all attachments as: .zip

Change History (7)

Changed 14 years ago by William Stein

Attachment: sage-4262.patch added

comment:1 Changed 14 years ago by William Stein

Summary: Elliptic curve a_invariants command returns a list reference (BAD!!)[with patch; needs review] Elliptic curve a_invariants command returns a list reference (BAD!!)


comment:2 Changed 14 years ago by Martin Albrecht

Shouldn't we just return a tuple to emphasise that this is invariant?

comment:3 Changed 14 years ago by William Stein

Changing to tuples should be another ticket.

comment:4 Changed 14 years ago by Martin Albrecht

Summary: [with patch; needs review] Elliptic curve a_invariants command returns a list reference (BAD!!)[with patch; positive review] Elliptic curve a_invariants command returns a list reference (BAD!!)

comment:5 Changed 14 years ago by William Stein

See #4264 for changing to return a tuple.

comment:6 Changed 14 years ago by Michael Abshoff

Resolution: fixed
Status: newclosed

Merged in Sage 3.1.3.rc0

Note: See TracTickets for help on using tickets.