Opened 13 years ago

Closed 13 years ago

#4262 closed defect (fixed)

[with patch; positive review] Elliptic curve a_invariants command returns a list reference (BAD!!)

Reported by: was Owned by: was
Priority: major Milestone: sage-3.1.3
Component: number theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This sucks:

sage: E = EllipticCurve([1,0,0,0,1])
sage: E.a_invariants()[0] = 100000000
sage: E
Elliptic Curve defined by y^2 + 100000000*x*y  = x^3 +1 over Rational Field

Attachments (1)

sage-4262.patch (1.2 KB) - added by was 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by was

comment:1 Changed 13 years ago by was

  • Summary changed from Elliptic curve a_invariants command returns a list reference (BAD!!) to [with patch; needs review] Elliptic curve a_invariants command returns a list reference (BAD!!)


comment:2 Changed 13 years ago by malb

Shouldn't we just return a tuple to emphasise that this is invariant?

comment:3 Changed 13 years ago by was

Changing to tuples should be another ticket.

comment:4 Changed 13 years ago by malb

  • Summary changed from [with patch; needs review] Elliptic curve a_invariants command returns a list reference (BAD!!) to [with patch; positive review] Elliptic curve a_invariants command returns a list reference (BAD!!)

comment:5 Changed 13 years ago by was

See #4264 for changing to return a tuple.

comment:6 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.3.rc0

Note: See TracTickets for help on using tickets.