#4242 closed defect (fixed)
[with patch, positive reivew] Bugfix for dominates() method of partition.py
Reported by: | jbandlow | Owned by: | mhansen |
---|---|---|---|
Priority: | major | Milestone: | sage-3.1.3 |
Component: | combinatorics | Keywords: | |
Cc: | sage-combinat | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
p.dominates(q) would give the wrong answer (True) if q had more boxes than p, but the first (length of p) parts of q were dominated by p. Attached patch fixes this.
Attachments (2)
Change History (10)
Changed 14 years ago by
Attachment: | 4242.patch added |
---|
comment:1 Changed 14 years ago by
Summary: | Bugfix for dominates() method of partition.py (with patch; needs review) → [with patch, positive review] Bugfix for dominates() method of partition.py (with patch; needs review) |
---|
comment:2 Changed 14 years ago by
Summary: | [with patch, positive review] Bugfix for dominates() method of partition.py (with patch; needs review) → [with patch, positive review] Bugfix for dominates() method of partition.py |
---|
comment:3 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
Merged in Sage 3.1.3.alpha3
comment:4 Changed 14 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
With the patch applied I get
sage -t devel/sage/sage/combinat/partition.py ********************************************************************** File "/scratch/mabshoff/release-cycle/sage-3.1.3.alpha3/tmp/partition.py", line 604: sage: Partition([]).dominates([1]) Expected: False Got: True **********************************************************************
I assumed that at least the patched file would be doctested :(
Cheers,
Michael
comment:5 Changed 14 years ago by
Summary: | [with patch, positive review] Bugfix for dominates() method of partition.py → [with patch, needs work] Bugfix for dominates() method of partition.py |
---|
Changed 14 years ago by
Attachment: | trac_4242.patch added |
---|
comment:6 Changed 14 years ago by
Summary: | [with patch, needs work] Bugfix for dominates() method of partition.py → [with patch, positive reivew] Bugfix for dominates() method of partition.py |
---|
Looks good to me. Thanks Mike.
Cheers,
Michael
comment:7 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Merged in Sage 3.1.3.rc0
comment:8 Changed 14 years ago by
Cc: | sage-combinat added; jbandlow removed |
---|
Note: See
TracTickets for help on using
tickets.
Thanks Jason! Looks good to me.