Opened 13 years ago
Closed 13 years ago
#424 closed enhancement (fixed)
GMP development code for fast GCD
Reported by: | dmharvey | Owned by: | somebody |
---|---|---|---|
Priority: | major | Milestone: | sage-2.8.4 |
Component: | basic arithmetic | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
The GMP development page
has some code for fast GCD/XGCD of huge operands. It might not appear for a while in official releases, but they claim it's stable, and I'm interested in patching it into SAGE. I tried to do this and got stuck on configuration problems that a linux/GNU guru could help with.
Attachments (3)
Change History (8)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Well no, I *did* actually get the patch compiling in a standalone setting, after manually fiddling with autoconf (etc) output files. But I couldn't get it compiling in SAGE, now I can't quite remember why.
It might help to check out the doc/configuration file in GMP, which explains in some detail how to add new files to GMP.
comment:3 Changed 13 years ago by
I've attached an initial patch which I believe puts all the right files and new lines of code in the right places. I haven't tried building yet. Apply this patch by patch -p1 < gcd1.patch
in the gmp-4.2.1 directory.
comment:4 Changed 13 years ago by
I just attached a patch (fastgcd.hg
) which should be applied to the GMP spkg (gmp-4.2.1.p9.spkg
. BTW the file spkg-install~
should be deleted from that spkg too.) This patch supersedes the files gcd1.patch
and gcd2.patch
. This new patch adds all relevant files, and also modifies the build scripts. (It also addresses #605, I hope). I've tested it on OSX ppc and intel, haven't tested it on sage.math yet.
comment:5 Changed 13 years ago by
- Milestone set to sage-2.8.4
- Resolution set to fixed
- Status changed from new to closed
I tried for a while to get the patch to work. I think it doesn't work against the latest GMP release (plain vanilla), which is newer than the last change of that patch:
This isn't a problem with autoconf, etc., -- it s a problem with the patch simply not working.
William