Opened 11 years ago

Closed 11 years ago

#4231 closed defect (fixed)

[with patch, positive review] magma -- long input too verbose in some cases

Reported by: was Owned by: was
Priority: minor Milestone: sage-3.1.3
Component: interfaces Keywords:
Cc: GeorgSWeber Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by was)

When evaluating this in the notebook:

%magma
polt<t> := RationalFunctionField(Rationals());
R<w,x,y,z> := PolynomialRing(polt, 4);
Q0 := w^3 + x^3 + y^3 + z^3;
Q := (w+x)*(w+2*y)*(w+3*z) + 3*x*y*(w+x+z);
Qt := Q0 + t*Q;
Qt_gradient := [Derivative(Qt, w), Derivative(Qt, x), Derivative(Qt, y), Derivative(Qt, z)];
Qt_jac := IdealWithFixedBasis(Qt_gradient);
b := w*x*y*z;
temp := Coordinates(Qt_jac, 3*b*Q);
temp2 := Derivative(temp[1],w) + Derivative(temp[2],x) + Derivative(temp[3],y) + Derivative(temp[4],z);


> ---
> I get the funny error message:
> ---
> Loading
> "/home/r1/kedlaya/.sage//temp/DWORK.MIT.EDU/5272//interface//tmp5272"
> ---
> but I think the calculation goes through. I'm guessing this is because
> Magma is returning a long output which gets saved to  a temporary
> file. But does the notebook user really need to see this message? I
> don't.
>
> Incidentally, if I change the last line to the following two lines:
> ---
> temp2 := Derivative(temp[1],w) + Derivative(temp[2],x);
> temp2 := temp2 + Derivative(temp[3],y) + Derivative(temp[4],z);
> ---
> then I don't get any error message.
 
I believe that Sage uses temp files for inputs larger than a certain
size.  It seems this long input passed that size and you're seeing a
"verbose loading" message.  Not really an error message, but I'm sure
William can add it to his list of Magma interface things to do.

Attachments (1)

sage-4231.patch (2.1 KB) - added by was 11 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by was

  • Status changed from new to assigned

comment:2 Changed 11 years ago by GeorgSWeber

  • Cc GeorgSWeber added

comment:3 Changed 11 years ago by was

  • Description modified (diff)

Changed 11 years ago by was

comment:4 Changed 11 years ago by was

  • Summary changed from magma -- long input too verbose in some cases to [with patch; needs review] magma -- long input too verbose in some cases

comment:5 Changed 11 years ago by was

NOTE: I forgot some # optionals, yet again for the doctests. Those will be in #4240, which should be done within a day.

comment:6 Changed 11 years ago by GeorgSWeber

  • Summary changed from [with patch; needs review] magma -- long input too verbose in some cases to [with patch, positive review] magma -- long input too verbose in some cases

The first half of the patch does indeed fix the issue reported.

The second half of this patch adds a doctest showing that the patch really works, more precisely this doctest fails without the patch.

However the new doctest fails also (earlier) if no local magma install may be found.

I'd vote nevertheless to take this patch in right now; and then apply #4240 as soon as possible. Other solution would imply having to change the patch(es) in #4240 accordingly, which seems to be superfluous work.

comment:7 Changed 11 years ago by mabshoff

  • Milestone changed from sage-3.1.3 to sage-3.2

Better luck next time since I don't want to break the followup patch - which is not ready for review and either way itself needs to add a couple #optional tags anyway.

Cheers,

Michael

comment:8 Changed 11 years ago by mabshoff

  • Milestone changed from sage-3.2 to sage-3.1.3
  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.1.3.rc0

Note: See TracTickets for help on using tickets.