Opened 13 years ago

Closed 13 years ago

#4145 closed defect (fixed)

[with patch, positive review] linear codes list function is slow

Reported by: rlm Owned by: tbd
Priority: major Milestone: sage-3.1.3
Component: algebra Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Before:

sage: G = ExtendedBinaryGolayCode()
sage: time L = G.list()
CPU times: user 16.24 s, sys: 0.32 s, total: 16.57 s
Wall time: 17.14 s

After:

sage: G = ExtendedBinaryGolayCode()
sage: time L = G.list()
CPU times: user 3.65 s, sys: 0.04 s, total: 3.68 s
Wall time: 3.71 s

Attachments (1)

trac_4145-lin-codes-slow.patch (962 bytes) - added by rlm 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by rlm

comment:1 Changed 13 years ago by rlm

comment:2 Changed 13 years ago by wdj

  • Summary changed from [with patch, needs review] linear codes list function is slow to [with patch, positive review] linear codes list function is slow

This is obviously correct (the code is 1 line). I didn't know about the list method for vector spaces but I'd not surprised that that list method is a great deal faster and more efficient that the current LinearCodes? one.

I have tested this does fix the comment 13 in #4115. Thanks Robert!

comment:3 Changed 13 years ago by mabshoff

  • Milestone set to sage-3.1.3
  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.3.alpha0

Note: See TracTickets for help on using tickets.