Opened 13 years ago

Closed 13 years ago

#4131 closed defect (fixed)

[with patch, positive review] unbreak sage-clone

Reported by: mabshoff Owned by: mabshoff
Priority: major Milestone: sage-3.1.2
Component: build Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Some bash code snuck into the python script sage-clone. This patch fixes it.

Cheers,

Michael

Attachments (1)

trac_4131.patch (726 bytes) - added by mabshoff 13 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 13 years ago by mabshoff

  • Status changed from new to assigned

Changed 13 years ago by mabshoff

comment:2 Changed 13 years ago by mhansen

  • Summary changed from [with patch, needs review] unbreak sage-clone to [with patch, positive review] unbreak sage-clone

Oops. :-)

comment:3 Changed 13 years ago by wdj

I'm confused:

wdj@hera:~/sagefiles/sage-3.1.2.rc4$ ./sage
----------------------------------------------------------------------
| SAGE Version 3.1.2.rc4, Release Date: 2008-09-15                   |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------

sage: hg_sage.apply("/home/wdj/sagefiles/trac_4131.patch")
cd "/home/wdj/sagefiles/sage-3.1.2.rc4/devel/sage" && hg status
cd "/home/wdj/sagefiles/sage-3.1.2.rc4/devel/sage" && hg status
cd "/home/wdj/sagefiles/sage-3.1.2.rc4/devel/sage" && hg import   "/home/wdj/sagefiles/trac_4131.patch"
applying /home/wdj/sagefiles/trac_4131.patch
unable to find 'sage-clone' for patching
1 out of 1 hunk FAILED -- saving rejects to file sage-clone.rej
abort: patch failed to apply
sage:                                                

I see sage-clone in /home/wdj/sagefiles/sage-3.1.2.rc4/local/bin, so what the heck is going on?

comment:4 Changed 13 years ago by mhansen

You use hg_scripts.apply() to apply this patch.

comment:5 Changed 13 years ago by wdj

Thanks. Applied fine now and sage -clone is working:-)

comment:6 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.1.2.rc5

Note: See TracTickets for help on using tickets.