Opened 13 years ago

Closed 13 years ago

#4103 closed defect (fixed)

[with patch, positive review] Delete the cmap option for vector field plots

Reported by: jason Owned by: was
Priority: minor Milestone: sage-3.1.3
Component: graphics Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The cmap argument for vector field plots is not used. Does anyone know why it's there? I don't think it's even valid matplotlib code.

This patch deletes the option.

Attachments (1)

plot_vector_field_cmap.patch (2.1 KB) - added by jason 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by jason

comment:1 Changed 13 years ago by jason

  • Summary changed from Delete the cmap option for vector field plots to [with patch, needs review] Delete the cmap option for vector field plots

comment:2 Changed 13 years ago by mabshoff

  • Summary changed from [with patch, needs review] Delete the cmap option for vector field plots to [with patch, positive review] Delete the cmap option for vector field plots

Patch looks good to me. Assuming it passes doctests (which are running now) this is a positive review.

Cheers,

Michael

comment:3 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.3.alpha0

Note: See TracTickets for help on using tickets.