Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#4101 closed defect (fixed)

[with spkg, positive review] cpdef horribly broken in last Cython

Reported by: robertwb Owned by: mabshoff
Priority: blocker Milestone: sage-3.1.2
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The way cpdef functions were implemented broke in some classes when being used across modules. This came up now because the new coercion uses cpdef much more. This is just the old cython+bug fix rather than a new release for time reasons, and passes sage -testall with the attached (nearly trivial) patch. A sage -ba is required.

​http://sage.math.washington.edu/home/robertwb/cython/cython-0.9.8.1.1p1.spkg

Attachments (1)

4101-cpdef-fix.patch​ (1.2 KB) - added by robertwb 13 years ago.

Download all attachments as: .zip

Change History (6)

Changed 13 years ago by robertwb

comment:1 Changed 13 years ago by mabshoff

Hi Robert,

I fixed some issues in the spkg, which is now at

​http://sage.math.washington.edu/home/mabshoff/release-cycles-3.1.2/rc2/cython-0.9.8.1.1.p0.spkg

Note that the patch level usually starts at p0 and that the name of the spkg and the directory name were not in sync.

I am testing the spkg with the patch to the Sage library applied right now, so expect a review in about 45 minutes.

Cheers,

Michael

comment:2 Changed 13 years ago by mabshoff

  • Summary changed from [with spkg, needs review] cpdef horribly broken in last Cython to [with spkg, positive review] cpdef horribly broken in last Cython

Spkg and a following -ba passes doctests. Positive review. Let's hope this spkg does not bite us in the ass so late in the release cycle :)

Cheers,

Michael

comment:3 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.2.rc2

comment:4 follow-up: Changed 13 years ago by robertwb

Thanks. I realized later that I had changed the name of the spkg rather than the folder name, but I was at work by then.

This is intentionally a p0 rather than the next release, so I'm pretty sure it won't bite us. (Famous last words...)

comment:5 in reply to: ↑ 4 Changed 13 years ago by mabshoff

Replying to robertwb:

Thanks. I realized later that I had changed the name of the spkg rather than the folder name, but I was at work by then.

Cool. It would be nice if you could base future cython.spkg off this on in 3.1.2.rc2. I did some fixed to spkg-install and SPKG.txt. It would also be great if you could add to the changes in SPKG.txt once you update it.

This is intentionally a p0 rather than the next release, so I'm pretty sure it won't bite us.

Well, the name was p1, so that was mostly my point. I fully understand that you added only one patch on top of the latest Cython release.

(Famous last words...)

Yeah, what could go wrong :)

I am valgrinding the startup of 3.1.2.rc2 to see if anything fishy was introduced.

Cheers,

Michael

Note: See TracTickets for help on using tickets.