Opened 13 years ago
Closed 12 years ago
#4036 closed enhancement (duplicate)
minor improvements to the Axiom interface
Reported by: | mhansen | Owned by: | was |
---|---|---|---|
Priority: | minor | Milestone: | sage-duplicate/invalid/wontfix |
Component: | interfaces | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Attachments (5)
Change History (15)
Changed 13 years ago by
Changed 13 years ago by
Changed 13 years ago by
comment:1 Changed 13 years ago by
- Summary changed from [with patch, needs review] minor improvements to the Axiom interface to [with patch, positive review pending] minor improvements to the Axiom interface
comment:2 Changed 13 years ago by
- Summary changed from [with patch, positive review pending] minor improvements to the Axiom interface to [with patch, positive review] minor improvements to the Axiom interface
...both of which failed before applying too. Looks good to me!
comment:3 Changed 13 years ago by
This patch introduces the following problem:
********************************************************************** File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/tmp/parent.py", line 13: sage: gp(2) + gap(3) Exception raised: Traceback (most recent call last): File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/doctest.py", line 1228, in __run compileflags, 1) in test.globs File "<doctest __main__.example_0[2]>", line 1, in <module> gp(Integer(2)) + gap(Integer(3))###line 13: sage: gp(2) + gap(3) File "element.pyx", line 718, in sage.structure.element.ModuleElement.__add__ (sage/structure/element.c:5748) return coercion_model.bin_op(left, right, add) File "coerce.pyx", line 662, in sage.structure.coerce.CoercionModel_cache_maps.bin_op (sage/structure/coerce.c:6364) raise TypeError, arith_error_message(x,y,op) TypeError: unsupported operand parent(s) for '+': 'GP/PARI interpreter' and 'Gap' **********************************************************************
Cheers,
Michael
comment:4 Changed 13 years ago by
- Summary changed from [with patch, positive review] minor improvements to the Axiom interface to [with patch, needs work] minor improvements to the Axiom interface
And this one, too:
sage -t -long devel/sage/sage/matrix/matrix_symbolic_dense.pyx ********************************************************************** File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/tmp/matrix_symbolic_dense.py", line 185: sage: print "ignore this"; hash(maxima(m)) #random due to architecture dependence Exception raised: Traceback (most recent call last): File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/doctest.py", line 1228, in __run compileflags, 1) in test.globs File "<doctest __main__.example_10[5]>", line 1, in <module> print "ignore this"; hash(maxima(m)) #random due to architecture dependence###line 185: sage: print "ignore this"; hash(maxima(m)) #random due to architecture dependence File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/site-packages/sage/interfaces/expect.py", line 984, in __call__ return self._coerce_from_special_method(x) File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/site-packages/sage/interfaces/expect.py", line 1008, in _coerce_from_special_method return (x.__getattribute__(s))(self) File "matrix_symbolic_dense.pyx", line 383, in sage.matrix.matrix_symbolic_dense.Matrix_symbolic_dense._maxima_ (sage/matrix/matrix_symbolic_dense.c:3536) File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/site-packages/sage/interfaces/expect.py", line 977, in __call__ return self(x._sage_()) File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/site-packages/sage/interfaces/maxima.py", line 1440, in _sage_ return symbolic_expression_from_maxima_string(repr(self)) File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/site-packages/sage/calculus/calculus.py", line 8515, in symbolic_expression_from_maxima_string raise TypeError, "unable to make sense of Maxima expression '%s' in SAGE"%s TypeError: unable to make sense of Maxima expression 'matrix([sqrt(2),3],[pi,e])' in SAGE ********************************************************************** File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/tmp/matrix_symbolic_dense.py", line 377: sage: m._maxima_(maxima) Exception raised: Traceback (most recent call last): File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/doctest.py", line 1228, in __run compileflags, 1) in test.globs File "<doctest __main__.example_17[4]>", line 1, in <module> m._maxima_(maxima)###line 377: sage: m._maxima_(maxima) File "matrix_symbolic_dense.pyx", line 383, in sage.matrix.matrix_symbolic_dense.Matrix_symbolic_dense._maxima_ (sage/matrix/matrix_symbolic_dense.c:3536) File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/site-packages/sage/interfaces/expect.py", line 977, in __call__ return self(x._sage_()) File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/site-packages/sage/interfaces/maxima.py", line 1440, in _sage_ return symbolic_expression_from_maxima_string(repr(self)) File "/scratch/mabshoff/release-cycle/sage-3.1.2.rc4/local/lib/python2.5/site-packages/sage/calculus/calculus.py", line 8515, in symbolic_expression_from_maxima_string raise TypeError, "unable to make sense of Maxima expression '%s' in SAGE"%s TypeError: unable to make sense of Maxima expression 'matrix([sqrt(2),3],[pi,e])' in SAGE **********************************************************************
Changed 13 years ago by
comment:5 Changed 13 years ago by
This patch should fix the issues.
comment:6 Changed 12 years ago by
- Summary changed from [with patch, needs work] minor improvements to the Axiom interface to [with patch, needs review] minor improvements to the Axiom interface
We need a review for the four patches together. The issue rlm saw is unrelated to this patch.
Cheers,
Michael
comment:7 Changed 12 years ago by
- Summary changed from [with patch, needs review] minor improvements to the Axiom interface to [with patch, needs rebase] minor improvements to the Axiom interface
This needs to be rebased against sage-3.2.1.*:
was@sage:~/build/sage-3.2.1.alpha1$ ./sage ---------------------------------------------------------------------- | Sage Version 3.2.1.alpha1, Release Date: 2008-11-26 | | Type notebook() for the GUI, and license() for information. | ---------------------------------------------------------------------- sage: hg_sage.apply('http://trac.sagemath.org/sage_trac/attachment/ticket/4036/trac_4036.patch') Attempting to load remote file: http://trac.sagemath.org/sage_trac/attachment/ticket/4036/trac_4036.patch?format=raw Loading: [.] cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg status cd "/home/was/build/sage-3.2.1.alpha1/devel/sage" && hg import "/home/was/.sage/temp/sage/10714/tmp_0.patch" applying /home/was/.sage/temp/sage/10714/tmp_0.patch patching file sage/rings/integer_mod.pyx Hunk #1 FAILED at 361 1 out of 1 hunk FAILED -- saving rejects to file sage/rings/integer_mod.pyx.rej abort: patch failed to apply
comment:8 Changed 12 years ago by
The content of these patches seems to have already been applied. In fact, most have been expanded with tests for fricas. I added some more tests for fricas, if desired.
Adam
comment:9 Changed 12 years ago by
Thinking about it. I think it would be less confusing if this ticket is just closed and anything new for fricas put into a new one. ~ Adam
comment:10 Changed 12 years ago by
- Milestone changed from sage-4.1.3 to sage-duplicate/invalid/wontfix
- Resolution set to duplicate
- Status changed from new to closed
- Summary changed from [with patch, needs rebase] minor improvements to the Axiom interface to minor improvements to the Axiom interface
This was indeed fixed as part of #5111. I'm going ahead and closing it.
patches apply to 3.1.2.rc1 and doctests pass in
sage/interfaces
, with the following exceptions:This one passes, but...
And this one: