Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#4035 closed defect (fixed)

[with patch, positive review] fix optional doctests for multivariate polynomials

Reported by: malb Owned by: malb
Priority: major Milestone: sage-3.2
Component: commutative algebra Keywords:
Cc: mhansen Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

See attached patch.

Attachments (1)

m2_optional_doctests.patch (4.5 KB) - added by malb 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by malb

comment:1 Changed 13 years ago by malb

Gary, can you review this (I'm asking you since it involves M2)

comment:2 Changed 13 years ago by mabshoff

I assume this ticket depends on the series of changes you made starting with the number field support? As is the patch does not apply.

Cheers,

Michael

comment:3 Changed 13 years ago by malb

yeah, that could be.

comment:4 Changed 13 years ago by malb

  • Status changed from new to assigned

comment:5 Changed 13 years ago by mabshoff

  • Cc mhansen added; gfurnish removed
  • Summary changed from [with patch, needs review] fix optional doctests for multivariate polynomials to [with patch, needs review, needs rebase] fix optional doctests for multivariate polynomials

Unfortunately this patch has bitrotted:

mabshoff@sage:/scratch/mabshoff/release-cycle/sage-3.2.alpha1/devel/sage$ patch -p1 < trac_4035_m2_optional_doctests.patch 
patching file sage/rings/polynomial/multi_polynomial.pyx
patching file sage/rings/polynomial/multi_polynomial_ideal.py
Hunk #1 FAILED at 60.
Hunk #2 succeeded at 1659 (offset 58 lines).
Hunk #3 succeeded at 1883 (offset 64 lines).
Hunk #4 FAILED at 2031.
2 out of 4 hunks FAILED -- saving rejects to file sage/rings/polynomial/multi_polynomial_ideal.py.rej
patching file sage/rings/polynomial/multi_polynomial_ring.py

Mike: Once it is rebased can you review it?

Cheers,

Michael

comment:6 Changed 13 years ago by mabshoff

  • Milestone changed from sage-3.2.1 to sage-3.2
  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed via the patch at #4420.

Cheers,

Michael

comment:7 Changed 13 years ago by mabshoff

  • Summary changed from [with patch, needs review, needs rebase] fix optional doctests for multivariate polynomials to [with patch, positive review] fix optional doctests for multivariate polynomials
Note: See TracTickets for help on using tickets.