Opened 13 years ago
Closed 13 years ago
#4027 closed defect (fixed)
[with patch, positive review] Sage 3.1.2.alpha3: matrix_mod2_dense.pyx doctest failure on 32 bits
Reported by: | mabshoff | Owned by: | malb |
---|---|---|---|
Priority: | blocker | Milestone: | sage-3.1.2 |
Component: | doctest coverage | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
bash-3.2$ ./sage -t devel/sage/sage/matrix/matrix_mod2_dense.pyx sage -t devel/sage/sage/matrix/matrix_mod2_dense.pyx sh: line 1: 19961 Abort trap /Users/mabshoff/sage-3.1.2.alpha3/local/bin/python /Users/mabshoff/sage-3.1.2.alpha3/tmp/.doct est_matrix_mod2_dense.py > /var/folders/uO/uOBV9ZyXHvWiSlU9K+3AE++++UE/-Tmp-/tmpqHbQOr 2> /var/folders/uO/uOBV9ZyXHvWiSlU9K+3AE++++UE/-Tmp-/tmpBMZa3v ********************************************************************** File "/Users/mabshoff/sage-3.1.2.alpha3/tmp/matrix_mod2_dense.py", line 1496: sage: print A.str() Expected: [1 1 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 1 1 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [1 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0] [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Got: [1 1 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 1 1 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0] [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] ********************************************************************** File "/Users/mabshoff/sage-3.1.2.alpha3/tmp/matrix_mod2_dense.py", line 1501: sage: ZZ(sage.matrix.matrix_mod2_dense._read_bits(A,2,0,64)) Expected: 13835058055282163713 Got: 1 ********************************************************************** File "/Users/mabshoff/sage-3.1.2.alpha3/tmp/matrix_mod2_dense.py", line 1505: sage: print A.str() Expected: [1 1 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 1 1 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [1 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0] [0 1 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0] Got: [1 1 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 1 1 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0 0] [0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 1 0] ********************************************************************** File "/Users/mabshoff/sage-3.1.2.alpha3/tmp/matrix_mod2_dense.py", line 1510: sage: ZZ(sage.matrix.matrix_mod2_dense._read_bits(A,3,1,64)) Expected: 13835058055282163713 Got: 1 For whitespace errors, see the file /Users/mabshoff/sage-3.1.2.alpha3/tmp/.doctest_matrix_mod2_dense.pym4ri_mm_calloc: calloc returned NULL A mysterious error (perphaps a memory error?) occurred, which may have crashed doctest. [10.2 s] exit code: 768
Attachments (1)
Change History (7)
Changed 13 years ago by
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
- Summary changed from Sage 3.1.2.alpha3: matrix_mod2_dense.pyx doctest failure on 32 bits to [with patch, positive review] Sage 3.1.2.alpha3: matrix_mod2_dense.pyx doctest failure on 32 bits
Patch looks good to me. The calloc issue might or might not be solved by the new upstream spkg. If it is still a problem I will open a new ticket for it.
Cheers,
Michael
comment:3 Changed 13 years ago by
A new SPKG is up at:
http://sage.math.washington.edu/home/malb/spkgs/libm4ri-20080901.spkg
With that SPKG and a touch on matrix_mod2_dense.pxd
+ sage -b
all tests pass on BSD:
Sage subshell$ sage -t ~/sage-3.1.2.alpha3/devel/sage/sage/matrix/matrix_mod2_dense.pyx sage -t devel/sage/sage/matrix/matrix_mod2_dense.pyx [4.4 s] ---------------------------------------------------------------------- All tests passed! Total time for all tests: 4.4 seconds
comment:4 Changed 13 years ago by
- Summary changed from [with patch, positive review] Sage 3.1.2.alpha3: matrix_mod2_dense.pyx doctest failure on 32 bits to [with patch, needs review] Sage 3.1.2.alpha3: matrix_mod2_dense.pyx doctest failure on 32 bits
comment:5 Changed 13 years ago by
- Summary changed from [with patch, needs review] Sage 3.1.2.alpha3: matrix_mod2_dense.pyx doctest failure on 32 bits to [with patch, positive review] Sage 3.1.2.alpha3: matrix_mod2_dense.pyx doctest failure on 32 bits
The spkg has been reviewed at #4024, so I am giving the patch a positive review since it makes the doctest work on OSX 32 bit again.
Cheers,
Michael
comment:6 Changed 13 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.1.2.alpha4
Note: See
TracTickets for help on using
tickets.
The doctest failures can easily be fixed by disabling the respective code (it is just there for testing purposes and that code isn't used by anything in production use yet)
I'll have to come up with a second patch for the CALLOC issue.