Opened 14 years ago

Closed 14 years ago

#3967 closed defect (fixed)

[with patch, with positive review] Totallyreal "just print" feature added

Reported by: John Voight Owned by: John Voight
Priority: minor Milestone: sage-3.1.3
Component: number theory Keywords:
Cc: Craig Citro Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

I added a small feature to "just print" long lists of fields in totallyreal rather than storing them to memory. Patch attached.

Attachments (2)

9865.patch (3.8 KB) - added by John Voight 14 years ago.
trac-3967-rebase.patch (5.6 KB) - added by Craig Citro 14 years ago.
Rebased John's patch for 3.1.2, depends on trac #4155 (both patches)

Download all attachments as: .zip

Change History (12)

Changed 14 years ago by John Voight

Attachment: 9865.patch added

comment:1 Changed 14 years ago by Michael Abshoff

Cc: Craig Citro added
Milestone: sage-3.1.2
Summary: Totallyreal "just print" feature added[with patch, needs review] Totallyreal "just print" feature added

Craig,

you are the canonical person to review this small patch :)

Cheers,

Michael

comment:2 Changed 14 years ago by Craig Citro

Summary: [with patch, needs review] Totallyreal "just print" feature added[with patch, with positive review] Totallyreal "just print" feature added

This looks good. I went ahead and re-based this on 3.1.2 with my patch from #4155 applied, since it makes sense to apply that first.

John, you should at least glance to make sure I didn't mess anything up rewriting the patch, just for the sake of having a second set of eyes look at it.

comment:3 Changed 14 years ago by John Voight

Owner: changed from William Stein to John Voight
Status: newassigned

Yes, all looks well. I'm reviewing #4155 now. JV

comment:4 Changed 14 years ago by John Voight

Resolution: worksforme
Status: assignedclosed

comment:5 Changed 14 years ago by John Voight

Resolution: worksforme
Status: closedreopened

comment:6 Changed 14 years ago by John Voight

Sorry to be such a tool about changing the status of this ticket. I wasn't sure what to set it to so as to indicate that it is ready for inclusion, once #4155 gets resolved. JV

comment:7 Changed 14 years ago by Michael Abshoff

Hi John,

FYI: the release manager closes a ticket once it is merged/determined to be invalied/etc.

Cheers,

Michael

comment:8 Changed 14 years ago by Michael Abshoff

Craig,

the rebased patch is broken: Toward the end you do not rename jp to jp_file and hence things do not compile. I will fix this in my tree and do some valgrinding.

Cheers,

Michael

comment:9 Changed 14 years ago by Craig Citro

Oops ... you were absolutely right, mabshoff. I've fixed it up, and tested it out.

Changed 14 years ago by Craig Citro

Attachment: trac-3967-rebase.patch added

Rebased John's patch for 3.1.2, depends on trac #4155 (both patches)

comment:10 Changed 14 years ago by Michael Abshoff

Resolution: fixed
Status: reopenedclosed

Merged trac-3967-rebase.patch in Sage 3.1.3.alpha1

Note: See TracTickets for help on using tickets.