Opened 11 years ago

Closed 11 years ago

#3926 closed defect (fixed)

[with spkg, positive review] fix Macaulay2 building

Reported by: malb Owned by: mabshoff
Priority: minor Milestone: sage-3.1.2
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

I've uploaded a new SPKG for M2 to:

http://sage.math.washington.edu/home/malb/spkgs/macaulay2-1.1-r7210.p1.spkg

which fixes a couple of compilation problems:

  • UNAME might not be defined
  • some standard headers are not included in overflow.hpp

Change History (3)

comment:1 Changed 11 years ago by mabshoff

  • Summary changed from [with spkg, needs review] fix Macaulay2 building to [with spkg, positive review] fix Macaulay2 building

Positive review. A couple remarks:

  • The fixes malb did should go upstream.
  • I fixed the boehm_gc and gdbm detection code since it only works for default spkgs and not optional ones - my bad.

Cheers,

Michael

comment:2 Changed 11 years ago by mabshoff

Oops, I forgot to mention that the updated spkg is at

http://sage.math.washington.edu/home/mabshoff/release-cycles-3.1.2/alpha1/macaulay2-1.1-r7210.p1.spkg

Cheers,

Michael

comment:3 Changed 11 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.2.alpha1

Note: See TracTickets for help on using tickets.