Opened 14 years ago

Closed 14 years ago

#3923 closed enhancement (fixed)

[with patch, positive review] notebook -- convert existing templates to Jinja templates

Reported by: Timothy Clemans Owned by: Mike Hansen
Priority: major Milestone: sage-3.2
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Requires the Jinja Template Engine http://jinja.pocoo.org/2/

Attachments (7)

sage-3923_1.patch (3.3 KB) - added by Timothy Clemans 14 years ago.
extcode-3923_1.patch (6.8 KB) - added by Timothy Clemans 14 years ago.
extcode-3923_2.patch (6.2 KB) - added by Timothy Clemans 14 years ago.
sage-3923_2.patch (12.2 KB) - added by Timothy Clemans 14 years ago.
sage-3923_3.patch (4.4 KB) - added by Timothy Clemans 14 years ago.
extcode-3923_3.patch (6.0 KB) - added by Timothy Clemans 14 years ago.
removes old files
trac_3923.patch (22.5 KB) - added by Mike Hansen 14 years ago.

Download all attachments as: .zip

Change History (14)

Changed 14 years ago by Timothy Clemans

Attachment: sage-3923_1.patch added

Changed 14 years ago by Timothy Clemans

Attachment: extcode-3923_1.patch added

Changed 14 years ago by Timothy Clemans

Attachment: extcode-3923_2.patch added

Changed 14 years ago by Timothy Clemans

Attachment: sage-3923_2.patch added

Changed 14 years ago by Timothy Clemans

Attachment: sage-3923_3.patch added

Changed 14 years ago by Timothy Clemans

Attachment: extcode-3923_3.patch added

removes old files

comment:1 Changed 14 years ago by Timothy Clemans

Summary: [with patch, not ready for review] notebook -- convert existing templates to Jinja templates[with patch, needs review] notebook -- convert existing templates to Jinja templates

comment:2 Changed 14 years ago by Martin Albrecht

Summary: [with patch, needs review] notebook -- convert existing templates to Jinja templates[with patch, needs jinja] notebook -- convert existing templates to Jinja templates

I think that this is not ready for review until Jinja is in Sage, if it ever gets into Sage.

comment:3 in reply to:  2 ; Changed 14 years ago by Michael Abshoff

Replying to malb:

I think that this is not ready for review until Jinja is in Sage, if it ever gets into Sage.

Jinja is required for the ReST transition of the documentation, so I am very bullish that it will get in. In total the ReST tool chain in 4 spkg weights in at 2MB compressed total and since it is a large improvement over the current situation with latex2html I think it will happen soon. Mike Hansen is pretty much ready to go here and it seems likely that those changes will be in 3.2.x if not 3.2 (assuming the spkgs get voted in obviously :))

Cheers,

Michael

comment:4 in reply to:  3 ; Changed 14 years ago by Martin Albrecht

Replying to mabshoff:

Jinja is required for the ReST transition of the documentation, so I am very bullish that it will get in. In total the ReST tool chain in 4 spkg weights in at 2MB compressed total and since it is a large improvement over the current situation with latex2html I think it will happen soon. Mike Hansen is pretty much ready to go here and it seems likely that those changes will be in 3.2.x if not 3.2 (assuming the spkgs get voted in obviously :))

Don't get me wrong, I'm all in favor of Jinja getting in, but this still needs formal verification. Also, IIRC there is the issue of Jinja v1 (ReST) vs. v2 (this patch)?

comment:5 in reply to:  4 Changed 14 years ago by Michael Abshoff

Replying to malb:

Don't get me wrong, I'm all in favor of Jinja getting in, but this still needs formal verification. Also, IIRC there is the issue of Jinja v1 (ReST) vs. v2 (this patch)?

Sure, I agree. Mike has figured out IIRC that both Jinja and ReST and this code plays well together with Jinja v2. Timothy should have actually checked with [sage-devel] formally before going off into the sunset and code up loads of features that the code in question would actually be merged. But this story is likely to have a happy end :). Hopefully everyone involved here will learn a lesson from this.

Cheers,

Michael

Changed 14 years ago by Mike Hansen

Attachment: trac_3923.patch added

comment:6 Changed 14 years ago by Mike Hansen

Owner: changed from Kelly Boothby to Mike Hansen
Status: newassigned
Summary: [with patch, needs jinja] notebook -- convert existing templates to Jinja templates[with patch, positive review] notebook -- convert existing templates to Jinja templates

I rebased the patches against 3.2.alpha0, moved the templates from extcode to sage/server/notebook/templates/, and changed the imports to use Jinja1 instead of Jinja2.

Apply only trac_3923.patch.

comment:7 Changed 14 years ago by Michael Abshoff

Resolution: fixed
Status: assignedclosed

Merged trac_3923.patch in Sage 3.2.alpha1

Note: See TracTickets for help on using tickets.