Opened 14 years ago

Closed 14 years ago

#3901 closed enhancement (fixed)

[with patch; positive review] automated doctesting elementary number theory book

Reported by: William Stein Owned by: Michael Abshoff
Priority: major Milestone: sage-3.2
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

10:49 < cwitty> wstein: You should put a file in Sage with all your code samples from your number theory book as 
                doctests.
10:49 < cwitty> Then we can't accidentally break your book.
10:49 < wstein> cwitty -- great idea.
10:49 < wstein> i'll make a ticket.

Same comments about my modular forms book.

Attachments (1)

sage-3901.patch (89.5 KB) - added by William Stein 14 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 14 years ago by William Stein

Type: defectenhancement

comment:2 Changed 14 years ago by William Stein

Summary: automated doctesting elementary number theory book[with patch; needs review] automated doctesting elementary number theory book

The attached patch creates two new files in the sage/tests/ directory.

  • book_stein_modform.py -- all examples in my AMS Modular Forms book.
  • book_stein_ent.py -- all examples in my new Springer Elementary Number Theory Book

This adds about 736 new lines of input examples to the Sage doctest suite, and adds about 45 seconds more time to doctesting.

Changed 14 years ago by William Stein

Attachment: sage-3901.patch added

comment:3 Changed 14 years ago by Mike Hansen

Summary: [with patch; needs review] automated doctesting elementary number theory book[with patch; positive review] automated doctesting elementary number theory book

Tests pass for me. It's good to get these in.

comment:4 Changed 14 years ago by Michael Abshoff

Note that coverage of those files is "bad" since we cannot deal with the autogenerated files:

mabshoff@sage:/scratch/mabshoff/release-cycle/sage-3.2.alpha1$ ./sage -coverageall devel/sage/sage/tests/
benchmark.py: 76% (87 of 114)
book_stein_ent.py: 0% (0 of 119)
book_stein_modform.py: 0% (0 of 51)

Overall weighted coverage score:  30.5%
Total number of functions:  284

Cheers,

Michael

comment:5 Changed 14 years ago by Michael Abshoff

Resolution: fixed
Status: newclosed

Merged in Sage 3.2.alpha1

Note: See TracTickets for help on using tickets.