Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3780 closed enhancement (fixed)

[with patch, positive review] add fast col_swap method for dense matrices over GF(2).

Reported by: malb Owned by: malb
Priority: major Milestone: sage-3.1.2
Component: linear algebra Keywords: m4ri
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by mhansen)

depends on #3324

Attachments (1)

m4ri_col_swap.patch (2.2 KB) - added by malb 11 years ago.

Download all attachments as: .zip

Change History (8)

Changed 11 years ago by malb

comment:1 Changed 11 years ago by mhansen

  • Summary changed from [with patch, depends on #3324 to [with patch, needs review] depends on #3324

comment:2 Changed 11 years ago by mhansen

  • Description modified (diff)
  • Summary changed from [with patch, needs review] depends on #3324 to [with patch, needs review] add fast col_swap method for dense matrices over GF(2).

comment:3 Changed 11 years ago by rlm

  • Summary changed from [with patch, needs review] add fast col_swap method for dense matrices over GF(2). to [with patch, positive review] add fast col_swap method for dense matrices over GF(2).

I haven't tested this, but it looks fine. If it works, apply.

comment:4 Changed 11 years ago by rlm

...other than the missing output from the last doctest! :-[

comment:5 Changed 11 years ago by mabshoff

Note that the doctests only pass with #3376 applied, where the missing output that rlm mentions above is actually added :)

Cheers,

Michael

comment:6 Changed 11 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.2.alpha3

comment:7 Changed 11 years ago by mabshoff

Note that the patch attached to this ticket is a diff. I did commit it in Martin's name.

Cheers,

Michael

Note: See TracTickets for help on using tickets.