#3744 closed defect (fixed)
[with patch, positive review] Coercion between isomorphic parents should result in an element of the left operand's parent
Reported by: | robertwb | Owned by: | robertwb |
---|---|---|---|
Priority: | major | Milestone: | sage-3.1 |
Component: | coercion | Keywords: | |
Cc: | Merged in: | ||
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
This is in accordance with the programming guide.
Attachments (1)
Change History (8)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Summary changed from Coercion between isomorphic parents should result in an element of the left operand's parent to [with patch, needs review] Coercion between isomorphic parents should result in an element of the left operand's parent
comment:2 Changed 11 years ago by
- Summary changed from [with patch, needs review] Coercion between isomorphic parents should result in an element of the left operand's parent to [with patch, negative review] Coercion between isomorphic parents should result in an element of the left operand's parent
comment:3 Changed 11 years ago by
- Summary changed from [with patch, negative review] Coercion between isomorphic parents should result in an element of the left operand's parent to [with patch, waiting on new coercion] Coercion between isomorphic parents should result in an element of the left operand's parent
Let's wait until #3738 gets in.
comment:4 Changed 11 years ago by
Still does not apply cleanly to 3.1.alpha2:
---------------------------------------------------------------------- | SAGE Version 3.1.alpha2, Release Date: 2008-08-13 | | Type notebook() for the GUI, and license() for information. | ---------------------------------------------------------------------- Loading SAGE library. Current Mercurial branch is: 3744 sage: hg_sage.apply("/home/john/3744-coercion-left.patch") cd "/home/john/sage-3.1.alpha2/devel/sage" && hg status cd "/home/john/sage-3.1.alpha2/devel/sage" && hg status cd "/home/john/sage-3.1.alpha2/devel/sage" && hg import "/home/john/3744-coercion-left.patch" applying /home/john/3744-coercion-left.patch patching file sage/structure/coerce.pyx Hunk #1 succeeded at 845 with fuzz 2 (offset 105 lines). Hunk #2 FAILED at 780 1 out of 2 hunks FAILED -- saving rejects to file sage/structure/coerce.pyx.rej abort: patch failed to apply
comment:5 Changed 11 years ago by
This is actually in 3.1.alpha2 and has been reviewed via #3738, so I am giving this a positive reivew.
Cheers,
Michael
comment:6 Changed 11 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.1.alpha2
comment:7 Changed 11 years ago by
- Summary changed from [with patch, waiting on new coercion] Coercion between isomorphic parents should result in an element of the left operand's parent to [with patch, positive review] Coercion between isomorphic parents should result in an element of the left operand's parent
Well, I really ought to change the subject, too.
Cheers,
Michael
Note: See
TracTickets for help on using
tickets.
This patch does not apply cleanly to 3.1.alpha0:
I'm not sure how it fits in with the main coercion model patches though.