Opened 13 years ago

Closed 13 years ago

#3703 closed defect (fixed)

[with patch, positive review] bug in set_edge_label

Reported by: rlm Owned by: rlm
Priority: major Milestone: sage-3.1
Component: graph theory Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

sage: G = Graph({0:{1:1}}, implementation='c_graph')
sage: G.num_edges()
1
sage: G.set_edge_label(0,1,1)
sage: G.num_edges()
2

Attachments (1)

trac3703-set_edge_label.patch (2.0 KB) - added by rlm 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by rlm

comment:1 Changed 13 years ago by jason

  • Summary changed from [with patch, needs review] bug in set_edge_label to [with patch, positive review] bug in set_edge_label

Positive review. Good catch!

Passes doctests in graphs/*.py, graphs/*.pyx, and graphs/base/*.pyx

comment:2 Changed 13 years ago by rlm

I spent most of a day hunting for this one; I wasn't expecting to find it where I did. I was writing new code, so I was convinced it was there...

comment:3 Changed 13 years ago by jason

That's a nice blog post you have talking about finding this bug:

http://rlmill.blogspot.com/2008/07/adinkras.html

comment:4 Changed 13 years ago by was

  • Milestone changed from sage-3.0.6 to sage-3.1

comment:5 follow-up: Changed 13 years ago by rlm

This has been sitting positively reviewed for several release cycles now. What's going on??

comment:6 in reply to: ↑ 5 Changed 13 years ago by mabshoff

Replying to rlm:

This has been sitting positively reviewed for several release cycles now. What's going on??

3.0.5 was supposed to be ultra stable, but one bug introduced mandated another 3.0.6 stable release. So this patch fell by the side. It will be merged in 3.1.alpha0 in a couple minutes provided the doctests pass.

Cheers,

Michael

comment:7 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.1.alpha0

Note: See TracTickets for help on using tickets.