Opened 12 years ago

Closed 11 years ago

#3686 closed defect (fixed)

[with patch, positive review] trivial problems in extcode.spkg

Reported by: tabbott Owned by: mabshoff
Priority: minor Milestone: sage-4.1.1
Component: packages: standard Keywords:
Cc: Merged in: Sage 4.1.1.alpha1
Authors: Tim Abbott Reviewers: Adam Webb
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Below is a list trivial problems in the excode spkg that were found by Debian's automatic package quality checking tools:

# Scripts missing #!/bin/sh lines in extcode-3.0.5.spkg: mirror pari/dokchitser/testall spkg-dist

# Files unnecessarily marked as executable in extcode-3.0.5.spkg javascript/jsmath/plugins/autoload.js javascript/jsmath/plugins/CHMmode.js notebook/javascript/jsmath/plugins/autoload.js notebook/javascript/jsmath/plugins/CHMmode.js notebook/javascript/farbtastic/marker.png

# Empty directories in extcode-3.0.5.spkg # (These look like they might have a purpose, but I'm not sure) dist/ gap/user/ genus2reduction/ gnuplot/ macaulay2/user/ maple/user/ mathematica/user/ matlab/user/ octave/user/ sage/user/ singular/user/ sobj/

Attachments (1)

extcode_shebang.patch (1.0 KB) - added by tabbott 12 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 12 years ago by tabbott

Let's display that readably:

# Scripts missing #!/bin/sh lines in extcode-3.0.5.spkg:

mirror
pari/dokchitser/testall
spkg-dist

# Files unnecessarily marked as executable in extcode-3.0.5.spkg

javascript/jsmath/plugins/autoload.js
javascript/jsmath/plugins/CHMmode.js
notebook/javascript/jsmath/plugins/autoload.js
notebook/javascript/jsmath/plugins/CHMmode.js
notebook/javascript/farbtastic/marker.png

# Empty directories in extcode-3.0.5.spkg # (These look like they might have a purpose, but I'm not sure)

dist/
gap/user/
genus2reduction/
gnuplot/
macaulay2/user/
maple/user/
mathematica/user/
matlab/user/
octave/user/
sage/user/
singular/user/
sobj/

Changed 12 years ago by tabbott

comment:2 Changed 12 years ago by tabbott

The Debian people made me fix all these problems myself, so I've attached patches to fix the #! lines to each of these tickets. You'll have to remove the executable bits yourself, since I seem to recall mercurial doesn't support that.

By the way, the empty directories in the extcode spkg are for the Sage pexpect wrapper, and can't be deleted. The others can.

comment:3 Changed 11 years ago by tabbott

  • Summary changed from trivial problems in extcode.spkg to [with patch, needs review] trivial problems in extcode.spkg

As well as applying the attached patch, one should run

chmod -x notebook/javascript/farbtastic/marker.png javascript/jsmath/plugins/CHMmode.js 
chmod -x javascript/jsmath/plugins/autoload.js notebook/javascript/jsmath/plugins/CHMmode.js 
chmod -x javascript/jsmath/plugins/CHMmode.js

from the root of the extcode spkg in order to close this ticket.

comment:4 Changed 11 years ago by awebb

notebook/javascript/jsmath/plugins/CHMmode.js does not seem to exist in extcode-4.1 otherwise the rest seems OK.

comment:5 Changed 11 years ago by awebb

  • Summary changed from [with patch, needs review] trivial problems in extcode.spkg to [with patch, positive review] trivial problems in extcode.spkg

I applied the patch and ran the chmod commands as suggested above. Ignoring the change in one file, everything else worked.

Note: I applied #3686, #3687, #3688 and #3689 at the same time as my machine is a bit slow (8800 s to run all tests). I changed the packages, did a full build from source and ran 'make testlong'. Everything built and all tests passed. This is with Sage-4.1.

comment:6 Changed 11 years ago by awebb

  • Reviewers set to Adam Webb

comment:7 Changed 11 years ago by mvngu

  • Authors set to Tim Abbott

comment:8 Changed 11 years ago by mvngu

  • Merged in set to Sage 4.1.1.alpha1
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.