Opened 11 years ago
Closed 11 years ago
#3676 closed enhancement (fixed)
[with patch, positive review] Refactor graph isom code.
Reported by: | rlm | Owned by: | rlm |
---|---|---|---|
Priority: | major | Milestone: | sage-3.1 |
Component: | combinatorics | Keywords: | graphs |
Cc: | boothby | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | Work issues: | ||
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
After this patch, graph_isom
will be essentially obsolete. Brought to the GNU General Public by Google, Inc.
Attachments (7)
Change History (21)
Changed 11 years ago by
comment:1 Changed 11 years ago by
- Cc boothby added
comment:2 Changed 11 years ago by
comment:3 Changed 11 years ago by
David,
the above doctest is a known issue and orthogonal to rlm's code. See #3634 for the patch that likely caused this.
Cheers,
Michael
comment:4 Changed 11 years ago by
Okay. I was just trying to help out with the doctesting, that's all. Seems like it tests fine then.
Changed 11 years ago by
comment:5 Changed 11 years ago by
It's so... readable...
Changed 11 years ago by
comment:6 Changed 11 years ago by
The patches here may depend on #3703.
Changed 11 years ago by
comment:7 Changed 11 years ago by
- Milestone changed from sage-3.1.1 to sage-3.1
Changed 11 years ago by
comment:8 Changed 11 years ago by
I can flatten those last three if desired...
comment:9 Changed 11 years ago by
Changed 11 years ago by
comment:10 Changed 11 years ago by
- Summary changed from [with patch, needs review] Refactor graph isom code. to [with patch, needs review, review in progress] Refactor graph isom code.
3676-ncalexan-docstring-changes.patch
changes some documentation to be clearer.
I am happy with this patch, save for a missing module docstring. rlmiller will write said docstring, explaining programming API to his code, and then this is ready for showtime.
Apply all patches in order.
comment:11 Changed 11 years ago by
Looks good to me.
comment:12 Changed 11 years ago by
The last patch is a flattened version of the previous ones, together with a recipe for implementing other objects. It should be finally ready to go. Apply only the last patch.
comment:13 Changed 11 years ago by
- Summary changed from [with patch, needs review, review in progress] Refactor graph isom code. to [with patch, positive review] Refactor graph isom code.
rlm and I have gone back and forth on this and I think it's great. I say apply!
comment:14 Changed 11 years ago by
- Resolution set to fixed
- Status changed from new to closed
Merged in Sage 3.1.alpha2
FYI, I got the following test failure: