Opened 14 years ago

Closed 14 years ago

Last modified 13 years ago

#3657 closed enhancement (fixed)

[with patch, positive review] Documentation for latin squares, DLXCPP; minor fixes

Reported by: carlohamalainen Owned by: mhansen
Priority: major Milestone: sage-3.0.6
Component: combinatorics Keywords: editor_mhansen
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Fixed some LaTeX problems so that the docs from latin.py would compile properly, also fixed some minor things.

Attachments (2)

chlatin.patch (16.7 KB) - added by carlohamalainen 14 years ago.
chlatindocs.patch (1.7 KB) - added by carlohamalainen 14 years ago.

Download all attachments as: .zip

Change History (7)

Changed 14 years ago by carlohamalainen

Changed 14 years ago by carlohamalainen

comment:1 Changed 14 years ago by mabshoff

  • Summary changed from [with patch against 3.0.5, needs review] Documentation for latin squares, DLXCPP; minor fixes to [with patch, needs review] Documentation for latin squares, DLXCPP; minor fixes

Carlo,

I have nuked the bundles. Not knowing the subject at hand I will not comment on chlatin.patch, but chlatindocs.patch looks good. The first hunk in the last patch will be removed when applying it, so don't worry about that for now.

Mike: Can you be the editor for this?

Cheers,

Michael

comment:2 Changed 14 years ago by mhansen

  • Keywords editor_mhansen added

comment:3 Changed 14 years ago by mhansen

  • Summary changed from [with patch, needs review] Documentation for latin squares, DLXCPP; minor fixes to [with patch, positive review] Documentation for latin squares, DLXCPP; minor fixes

With the exception of patchlevel.tex as Michael noted, everything else looks good to me. The sage-main tests applies and passes tests, and the documentation builds with both patches applied.

comment:4 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.6.alpha0

comment:5 Changed 13 years ago by nthiery

  • Cc sage-combinat added
Note: See TracTickets for help on using tickets.