Opened 13 years ago

Closed 13 years ago

#3651 closed defect (fixed)

[with patch, positive review] elliptic curves -- bug in L_ratio()

Reported by: cremona Owned by: was
Priority: major Milestone: sage-3.0.6
Component: number theory Keywords:
Cc: nbruin@… Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Nils Bruin reports:

"I ran into the following problem in sage, and I suspect it might be your code:

sage: EllipticCurve([0,0,0,-193^2,0]).sha().an()
[...]
NameError: global name 'misc' is not defined

Was this tested at all?"

It's a problem in L_ratio().

Attachments (1)

sage-trac3651.patch (1.1 KB) - added by cremona 13 years ago.

Download all attachments as: .zip

Change History (7)

Changed 13 years ago by cremona

comment:1 Changed 13 years ago by cremona

  • Summary changed from elliptic curves -- bug in L_ratio() to [with patch, needs review] elliptic curves -- bug in L_ratio()

After the attached patch (based on 3.0.4) it works fine:

sage: EllipticCurve([0,0,0,-193^2,0]).sha().an()
4

comment:2 Changed 13 years ago by mabshoff

  • Milestone set to sage-3.0.6

comment:3 Changed 13 years ago by wuthrich

Does not work with me, did you mean import sage.misc.misc as misc ?

comment:4 Changed 13 years ago by wuthrich

Sorry, my mistake; it works of course.

comment:5 Changed 13 years ago by mabshoff

  • Summary changed from [with patch, needs review] elliptic curves -- bug in L_ratio() to [with patch, positive review] elliptic curves -- bug in L_ratio()

Taking Chris' remark into account I am giving this a positive review.

Cheers,

Michael

comment:6 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.6.alpha0

Note: See TracTickets for help on using tickets.