Opened 14 years ago
Closed 8 years ago
#3624 closed enhancement (fixed)
cookbook documentation chapter: coding theory
Reported by:  wdj  Owned by:  tba 

Priority:  minor  Milestone:  sage6.4 
Component:  documentation  Keywords:  
Cc:  Merged in:  
Authors:  Ralf Stephan  Reviewers:  Kannappan Sampath 
Report Upstream:  N/A  Work issues:  
Branch:  66c7d05 (Commits, GitHub, GitLab)  Commit:  66c7d05c4f6e6df9645b3e67304156168f67ed20 
Dependencies:  Stopgaps: 
Description
I've put a draft for the coding theory chapter for the cookbook.tex document in http://sage.math.washington.edu/home/wdj/cookbook/ To possibly make it easier, I've created this tarball of the directory: http://sage.math.washington.edu/home/wdj/cookbook20080709.tar.gz
Attachments (1)
Change History (24)
comment:1 Changed 14 years ago by
 Milestone changed from sage3.1 to sage3.0.6
comment:2 Changed 14 years ago by
 Summary changed from cookbook documentation chapter: coding theory to [with protopatch, needs review?] cookbook documentation chapter: coding theory
Is this TeX code stand alone or is there a patch in there somewhere for the new cookbook? If so we should create the cookbook and migrate chapter by chapter over from the old construction manual. Once that is done we remove const.tex and all the other bits related to it.
Cheers,
Michael
comment:3 followup: ↓ 4 Changed 14 years ago by
I put a standalone latex file there (http://sage.math.washington.edu/home/wdj/cookbook/codingtheory/sagecodingcookbook.tex) for just that chapter (not in manual style) but also the full latex setup for a new subdirectory of SAGE_ROOT/devel/doc. I don't know how to make a patch to add a cookbook subdirectory to devel/doc. The programming guide discusses adding new files at http://sage.scipy.org/sage/doc/html/prog/node72.html The book http://hgbook.redbean.com/hgbook.html is hard to search through since the index is for page numbers but the html is in sections, not page numbers.
comment:4 in reply to: ↑ 3 Changed 14 years ago by
 Summary changed from [with protopatch, needs review?] cookbook documentation chapter: coding theory to [with protopatch, needs review] cookbook documentation chapter: coding theory
Replying to wdj:
I put a standalone latex file there (http://sage.math.washington.edu/home/wdj/cookbook/codingtheory/sagecodingcookbook.tex) for just that chapter (not in manual style) but also the full latex setup for a new subdirectory of SAGE_ROOT/devel/doc.
I've attached a patch to your file sagecodingcookbook.tex. It mainly fixes typos. I'm still waiting for sage3.1.4 to finish building on my machine, so at the moment I can't review the sample code in your file.
comment:5 Changed 13 years ago by
 Summary changed from [with protopatch, needs review] cookbook documentation chapter: coding theory to [with protopatch, needs work] cookbook documentation chapter: coding theory
comment:6 Changed 12 years ago by
 Report Upstream set to N/A
 Summary changed from [with protopatch, needs work] cookbook documentation chapter: coding theory to cookbook documentation chapter: coding theory
Ticket #8466 supersedes the current ticket.
comment:7 Changed 9 years ago by
 Milestone changed from sage5.11 to sage5.12
comment:8 Changed 8 years ago by
 Milestone changed from sage6.1 to sage6.2
comment:9 Changed 8 years ago by
 Branch set to u/rws/ticket/3624
 Modified changed from 01/30/14 21:20:52 to 01/30/14 21:20:52
comment:10 Changed 8 years ago by
 Commit set to 32fe92495ad7755444296ee185392347af0b2d3c
 Status changed from needs_work to needs_review
I took the latest corrected version of the paper, converted it to ReST using pandoc, and fixed that document, including a few typos. I converted the EPS figures to PNG using inkscape. The file is included in the toctree and the general index under number theory because I didn't want a toplevel entry. Maybe replace number theory with discrete math?
New commits:
32fe924  Trac #3624: added rst version of tex paper; include in indices

comment:11 Changed 8 years ago by
 Milestone changed from sage6.2 to sage6.3
comment:12 Changed 8 years ago by
 Status changed from needs_review to needs_work
sage t long src/doc/en/thematic_tutorials/coding_theory.rst Error: TAB character found at lines 860,864,865,.,.,.,1064
+Included in Sage is the group theory package GAP [GAP]_ and GUAVA [GUAVA]_, GA P’s coding +theory package. All of GUAVA’s functions can be accessed within Sage. + (calling Steve Linton’s C programs in GAP), +#. BooleanvalueTraceback (most recent call last): File "/home/ralf/sage/local/bin/patchbot/patchbot.py", line 468, in test_a_ticket res = plugin(ticket, is_git=True, baseline=baseline, **kwds) File "/home/ralf/git/sagepatchbot/src/plugins.py", line 149, in non_ascii exclude_new(ticket, regex=r'[^\x00\x7F]', msg="Nonascii characters", **kwds) File "/home/ralf/git/sagepatchbot/src/plugins.py", line 143, in exclude_new raise ValueError(full_msg) ValueError: Nonascii characters inserted on 35 nonempty lines
comment:13 Changed 8 years ago by
 Commit changed from 32fe92495ad7755444296ee185392347af0b2d3c to 48079fa331e1aa53f15d7c3460d93a94a09975d2
comment:14 Changed 8 years ago by
 Status changed from needs_work to needs_review
comment:15 Changed 8 years ago by
 Milestone changed from sage6.3 to sage6.4
comment:16 Changed 8 years ago by
Could you please rebase this on top of current release (and/or tell me how to do it)? This would be immensely helpful.
/p/s/ This should be an easy review for me but I have forgotten how to rebase a branch on top of another.
comment:17 Changed 8 years ago by
 Commit changed from 48079fa331e1aa53f15d7c3460d93a94a09975d2 to d1b24879bcfc33775cc173bf6f6e87cb41e8e655
Branch pushed to git repo; I updated commit sha1. New commits:
d1b2487  Merge branch 'develop' into t/3624/ticket/3624

comment:18 Changed 8 years ago by
 Reviewers set to Kannappan Sampath
 Status changed from needs_review to positive_review
I am setting this to Positive Review! Thank to the authors and editor for the great work on this branch!
comment:19 Changed 8 years ago by
Thanks for the review!
comment:20 Changed 8 years ago by
 Status changed from positive_review to needs_work
PDF docs don't build
l.14519 \end{gather} ? ! Emergency stop. \math@cr@@@ ...@ \@ne \add@amps \maxfields@ \omit \kern \alignsep@ \iftag@ ... l.14519 \end{gather} ! ==> Fatal error occurred, no output PDF file produced! Transcript written on thematic_tutorials.log. [23make[1]: *** [thematic_tutorials.pdf] Error 1 make[1]: Leaving directory `/home/release/Sage/src/doc/output/latex/en/thematic_tutorials' ]
comment:21 Changed 8 years ago by
 Commit changed from d1b24879bcfc33775cc173bf6f6e87cb41e8e655 to 66c7d05c4f6e6df9645b3e67304156168f67ed20
Branch pushed to git repo; I updated commit sha1. New commits:
66c7d05  3624: rename images, fix math

comment:22 Changed 8 years ago by
 Status changed from needs_work to positive_review
I really thought I had tested this.
comment:23 Changed 8 years ago by
 Branch changed from u/rws/ticket/3624 to 66c7d05c4f6e6df9645b3e67304156168f67ed20
 Resolution set to fixed
 Status changed from positive_review to closed
This is unrelated to coercion and should not be assigned against the coercion milestone. Right now 3.0.6 is the default milestone, so please assign new tickets against that milestone.
Cheers,
Michael