Opened 13 years ago

Closed 13 years ago

#3601 closed enhancement (fixed)

[with patch, positive review] Reimplementation of tensor products

Reported by: aschilling Owned by: Mike Hansen
Priority: minor Milestone: sage-3.0.6
Component: combinatorics Keywords: tensor products of crystals
Cc: sage-combinat-commits@… Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

I split TensorProductOfCrystals? into TensorProductOfCrystalsWithGenerators? and FullTensorProductOfCrystals? (with or without the option of being a classical crystal). This makes it possible to have a more efficient way to access list, count, etc for tensor products that do not have module generators.

Also, the distinction between the specifications of module_generators and highest_weight_vectors is made more precise (which made it necessary to slightly change the implementation of Daniel Bump on characters).

This change is necessary for the upcoming implementation of affine crystals.

Attachments (2)

tensor_product-for_trac.patch (9.4 KB) - added by aschilling 13 years ago.
tensor_product-3601-review.patch (5.5 KB) - added by mhansen 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by aschilling

Changed 13 years ago by mhansen

comment:1 Changed 13 years ago by mhansen

  • Summary changed from Reimplementation of tensor products to [with patch, under review by mhansen] Reimplementation of tensor products

Hi Anne,

I added a few doctests and fixed some whitespace issues (there were tabs instead of spaces). If you're fine with these changes, I'll go ahead and give it a positive review so it can get merged.

--Mike

comment:2 Changed 13 years ago by aschilling

Hi Mike,

Yes, your changes look fine to me (I wonder how the tabs instead of spaces happened to be wrong?).

Anne

comment:3 Changed 13 years ago by mhansen

  • Summary changed from [with patch, under review by mhansen] Reimplementation of tensor products to [with patch, positive by mhansen] Reimplementation of tensor products

I'm not sure. Usually the editor picks that up just fine.

comment:4 Changed 13 years ago by mabshoff

Anne, Mike,

to be 100% clear: both patches should be applied in this case?

Cheers,

Michael

comment:5 Changed 13 years ago by mhansen

Yes, both patches.

comment:6 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from [with patch, positive by mhansen] Reimplementation of tensor products to [with patch, positive review] Reimplementation of tensor products

Merged in Sage 3.0.6.alpha0

Note: See TracTickets for help on using tickets.