Opened 13 years ago

Closed 13 years ago

#3599 closed enhancement (fixed)

[with patch, positive review] Longer slider and labels on sliders

Reported by: itolkov Owned by: itolkov
Priority: major Milestone: sage-3.1
Component: notebook Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Slider update:

  • Sliders are now version 3, which is similar to current version 1, but longer
  • Label to the right of slider containing the current slider value (string representation), which is updated dynamically
  • User can hide label with "display_value=False".

Attachments (4)

trac3599_sage_1.patch (9.5 KB) - added by itolkov 13 years ago.
trac3599_extcode_1.patch (2.4 KB) - added by itolkov 13 years ago.
trac3599_extcode_2.patch (382 bytes) - added by was 13 years ago.
the image of the slider
slider-bg-3.png (239 bytes) - added by itolkov 13 years ago.
Here's the png again.

Download all attachments as: .zip

Change History (13)

Changed 13 years ago by itolkov

Changed 13 years ago by itolkov

comment:1 Changed 13 years ago by itolkov

  • Summary changed from Longer slider and labels on sliders to [with patch, needs review] Longer slider and labels on sliders

comment:2 Changed 13 years ago by itolkov

  • Priority changed from minor to major

comment:3 Changed 13 years ago by itolkov

  • Milestone set to sage-3.0.6

comment:4 Changed 13 years ago by jason

Where does the png file go?

comment:5 Changed 13 years ago by jason

  • Summary changed from [with patch, needs review] Longer slider and labels on sliders to [with patch, positive review] Longer slider and labels on sliders

Answering my question, it goes in:

$SAGE_ROOT/data/extcode/notebook/javascript/jqueryui/themes/flora/i/slider-bg-3.png

This patch seems to do what it claims and looks like reasonable code, looks nice, and doctests pass in sage/server/notebook/*.py

+1

Changed 13 years ago by was

the image of the slider

comment:6 Changed 13 years ago by was

I replaced the png by a proper patch.

comment:7 Changed 13 years ago by was

I give this another positive review, by the way. Very good.

comment:8 Changed 13 years ago by mabshoff

  • Summary changed from [with patch, positive review] Longer slider and labels on sliders to [with patch, positive review, partially merged] Longer slider and labels on sliders

Merged trac3599_sage_1.patch and trac3599_extcode_1.patch in Sage 3.1.alpha0. trac3599_extcode_2.patch is empty. You need to add a git style patch or reattach the png.

Cheers,

Michael

Changed 13 years ago by itolkov

Here's the png again.

comment:9 Changed 13 years ago by mabshoff

  • Milestone changed from sage-3.1.1 to sage-3.1
  • Resolution set to fixed
  • Status changed from new to closed
  • Summary changed from [with patch, positive review, partially merged] Longer slider and labels on sliders to [with patch, positive review] Longer slider and labels on sliders

Merged slider-bg-3.png in Sage 3.1.alpha0. Thanks Igor for the png. In the future please export a git style patch in case binaries are involved.

Cheers,

Michael

Note: See TracTickets for help on using tickets.