Opened 14 years ago

Closed 14 years ago

#3563 closed defect (fixed)

[with patch, positive review] sage/misc/cython.py: make "def atlas()" deal with the Accelerate Framework on OSX

Reported by: mabshoff Owned by: mabshoff
Priority: critical Milestone: sage-3.1.2
Component: build Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The review of #3530 exposed a bug hidden in sage/misc/cython.py: "def atlas()" would not return anything useful on OSX since we need to link against the Accelerate Framework.

Attachments (1)

trac_3563.2.patch (1.5 KB) - added by mabshoff 14 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 14 years ago by mabshoff

  • Milestone changed from sage-3.1.3 to sage-3.1.2
  • Status changed from new to assigned

This issue actually breaks Cython on OSX 10.4 since the linker fails after it complains about a missing ATLAS.

Cheers,

Michael

Changed 14 years ago by mabshoff

comment:2 Changed 14 years ago by mabshoff

  • Summary changed from sage/misc/cython.py: make "def atlas()" deal with the Accelerate Framework on OSX to [with patch, needs review] sage/misc/cython.py: make "def atlas()" deal with the Accelerate Framework on OSX

comment:3 Changed 14 years ago by rlm

  • Summary changed from [with patch, needs review] sage/misc/cython.py: make "def atlas()" deal with the Accelerate Framework on OSX to [with patch, positive review] sage/misc/cython.py: make "def atlas()" deal with the Accelerate Framework on OSX

Looks good to me, and

[05:11am] mabshoff: ok, fixed the tests, passes on OSX and not-OSX: #3563

comment:4 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from assigned to closed

Merged in Sage 3.1.2.rc4

Note: See TracTickets for help on using tickets.