Opened 13 years ago

Closed 13 years ago

#3561 closed defect (fixed)

[with patch; positive review] make it so sage does *not* import numpy by default on startup in totallyreal_data.pyx.

Reported by: was Owned by: cwitty
Priority: major Milestone: sage-3.0.4
Component: misc Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description


Attachments (1)

sage-3561.patch (3.7 KB) - added by was 13 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 13 years ago by was

  • Summary changed from make it so sage does *not* import numpy by default on startup. to [with patch; needs review] make it so sage does *not* import numpy by default on startup.

The attached patch gets rid of a bunch of numpy imports. However, according to

  sage -timeup

(see #3559) there is still some mysterious numpy import that gets triggered in real_double_vector.pyx. I'm very confused by that since there is no python "import numpy" anywhere there. Fixing that can be another ticket for later.

Changed 13 years ago by was

comment:2 Changed 13 years ago by mabshoff

  • Summary changed from [with patch; needs review] make it so sage does *not* import numpy by default on startup. to [with patch; positive review] make it so sage does *not* import numpy by default on startup.

Patch looks good to me. Positive review.

comment:3 Changed 13 years ago by mabshoff

  • Summary changed from [with patch; positive review] make it so sage does *not* import numpy by default on startup. to [with patch; positive review] make it so sage does *not* import numpy by default on startup in totallyreal_data.pyx.

comment:4 Changed 13 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.4.alpha2

Note: See TracTickets for help on using tickets.