Opened 14 years ago

Closed 14 years ago

#3559 closed enhancement (fixed)

[with patch; positive review] sage timeup script

Reported by: was Owned by: tbd
Priority: major Milestone: sage-3.0.4
Component: algebra Keywords: editor_mhansen
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Credit goes to Andrew Dalke, Mike Hansen, and William Stein (a little)

Attachments (2)

scripts-3559.patch (2.9 KB) - added by was 14 years ago.
scripts-3559-part2.patch (5.1 KB) - added by was 14 years ago.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by was

comment:1 Changed 14 years ago by mabshoff

  • Keywords editor_mhansen added

Since Mike is getting the author's permission so we can include this I am making him editor. Feel free to decline :)

Cheers,

Michael

comment:2 Changed 14 years ago by mhansen

    I was wondering if you'd be
    willing to release your code under a GPL compatible license so that we
    can include it with Sage to do regression testing with every release.


Certainly.

If you believe that

 This work written by Andrew Dalke and released into the public domain
 in 2008.  No copyright protection is asserted.

is sufficient then there you go.  Else

 Copyright Andrew Dalke, 2008. This software is provided 'as-is', without
 any express or implied warranty. In no event will the author be held
 liable for any damages arising from the use of this software.

 Permission is granted to anyone to use this software for any purpose,
 including commercial applications, and to alter it and redistribute it
 freely, subject to no restriction.

I honestly think that the code needs enough modifications to be usable in SAGE or another tool that nothing of my code will remain.

Now if had access to the code I wrote for a client, that would be much cooler.  It saved the imports to a format that kcachegrind could visualize.  :)

Cheers,


                               Andrew
                               dalke@dalkescientific.com

Changed 14 years ago by was

comment:3 Changed 14 years ago by mabshoff

  • Summary changed from [with patch; needs review] sage timeup script to [with patch; positive review] sage timeup script

Positive review. I think this is a nice start and will greatly help to keep the import time down.

Cheers,

Michael

comment:4 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged both patches in Sage 3.0.4.alpha2

Note: See TracTickets for help on using tickets.