Opened 11 years ago

Closed 5 years ago

#3525 closed enhancement (wontfix)

[with patches, don't review] notebook -- new welcome page

Reported by: TimothyClemans Owned by: TimothyClemans
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: notebook Keywords: editor_wstein, stale
Cc: Merged in:
Authors: Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Take the static page at http://timothyclemans.com/nb_homepage/ and merge it into the Sage Notebook code.

Attachments (6)

extcode-3525.patch (13.1 KB) - added by TimothyClemans 11 years ago.
sage-3525.patch (1.7 KB) - added by TimothyClemans 11 years ago.
extcode-3525_2.patch (4.4 KB) - added by TimothyClemans 11 years ago.
used Tidy to deal with point 5 of Harald's criticism
extcode-3525_3.patch (1.6 KB) - added by TimothyClemans 11 years ago.
extcode-3525_4.patch (1017 bytes) - added by TimothyClemans 11 years ago.
forgot to change which images are preloaded (the ones for signup and published worksheets)
extcode_combined.patch (47.8 KB) - added by TimothyClemans 11 years ago.

Download all attachments as: .zip

Change History (24)

Changed 11 years ago by TimothyClemans

comment:1 Changed 11 years ago by TimothyClemans

  • Component changed from number theory to notebook
  • Owner changed from was to TimothyClemans
  • Status changed from new to assigned
  • Summary changed from notebook -- new welcome page to [with patches, needs review] notebook -- new welcome page

Changed 11 years ago by TimothyClemans

comment:2 Changed 11 years ago by TimothyClemans

  • Keywords editor_wstein added

comment:3 Changed 11 years ago by TimothyClemans

From Harald Schilly:

Looks good, yes. Just small remarks what I would change...

1) The border around the sign-in formular is thin. Why not the same as
those two below? I would suggest to make all three borders small...

2) The top header is an image. The serif-italic letters don't look
very well on my screen. (no subpixel hinting compared to directly
rendered italic letters on my lcd) .. I would suggest to not use an
image, just the text string with a fixed font size (16pt?, italic,
serif) and absolute placement.

3) The forgot password page does not exist. I think, it should look
the same, except the login box and the middle content replaced by an
explanation and so on.

4) maybe less screenshots (just a 3x2 matrix) but with larger images?
so that someone could see more!

5) it's not xhtml valid
I strongly suggest to use xhtml transitional, since this is better for
compatibility and browsers like ie6 work better with that. xhtml
strict is just some sort of a more theoretical wish that will never
come true ;)
but anyways, ending a formular input tag with /> is not ok. browsers
don't understand real xml ...

6) maybe more margin-borders on the left and right side of the middle
content, to give everything a bit more "air" so that it looks less
tight...

greetings Harald


On Sat, Jun 28, 2008 at 08:38, William Stein <wstein@gmail.com> wrote:
> What do you think of
>
> http://timothyclemans.com/nb_homepage/
>
> --
> William Stein
> Associate Professor of Mathematics
> University of Washington
> http://wstein.org
>

Changed 11 years ago by TimothyClemans

used Tidy to deal with point 5 of Harald's criticism

comment:4 Changed 11 years ago by was

  • Summary changed from [with patches, needs review] notebook -- new welcome page to [with patches, needs works] notebook -- new welcome page

comment:5 Changed 11 years ago by TimothyClemans

Regarding the negative review could you tell me if you want all of Harald's suggestions implemented?

1) I can do easily by switching in the css which background is called for a:link and a:hover

2) Maybe do this in another ticket if others also complain

3) A very minimalistic "account recovery" page will be in sage-3.0.4. Anything regarding it should be a different ticket

4) I don't want to change them because A) I like it the way it is B) it would be very time consuming for me

5) Done

6) Sure

comment:6 Changed 11 years ago by was

For a positive review it is enough to do 1, 5, 6.

Changed 11 years ago by TimothyClemans

comment:7 Changed 11 years ago by TimothyClemans

  • Summary changed from [with patches, needs works] notebook -- new welcome page to [with patches, needs review] notebook -- new welcome page

margins increased blue line under interactive computer programming changed to reflect new margins

Border for "Sign up" and "Published worksheets" is now 1px.

Changed 11 years ago by TimothyClemans

forgot to change which images are preloaded (the ones for signup and published worksheets)

comment:8 Changed 11 years ago by TimothyClemans

In extcode-3525_3.patch I see

diff -r 84e3731cc21b -r 40c4b0aa9491 notebook/images/head.gif
Binary file notebook/images/head.gif has changed

Is the actual image stored in the patch? If not then how do I put package images for inclusion?

comment:9 Changed 11 years ago by TimothyClemans

extcode_combined.patch is a git style patch that should contained the required images

Changed 11 years ago by TimothyClemans

comment:10 Changed 11 years ago by TimothyClemans

  • Summary changed from [with patches, needs review] notebook -- new welcome page to [with patches, don't review] notebook -- new welcome page

The combined extcode patch is mess. Various fixes aren't in the patch ...

comment:11 Changed 9 years ago by jason

  • Report Upstream set to N/A

What is the status of this patch, Timothy?

comment:12 Changed 9 years ago by jason

  • Keywords stale added

comment:13 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:14 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:15 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:16 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:17 Changed 5 years ago by kcrisman

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_work to positive_review

This is not a bad idea in general, but at this point the discussion about looks are subsumed into ideas about "newUI" and "themes" upstream. Any new welcome page discussion should arrive there. Sadly, wontfix is probably most appropriate for this six-year-old ticket.

comment:18 Changed 5 years ago by vbraun

  • Resolution set to wontfix
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.