Opened 11 years ago

Closed 11 years ago

#3502 closed enhancement (fixed)

[with patch; positive review] modular symbols -- optimize fast computation of hecke eigenvalues on weight 2 modular symbols for gamma0

Reported by: was Owned by: craigcitro
Priority: major Milestone: sage-3.1.3
Component: modular forms Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by was)

  1. Implement applying Hecke operator to a single sparse vector, an operation that is needed for quick computation of systems of Hecke eigenvalues.
  1. Make very very fast code for applying many Hecke operators to a single vector with one nonzero entry.

NOTE: The higher weight patches (starting with patch 10) depend on upgrading flint, since flint had a bug: #3523.

NOTE: A cumulative bundle with all possible dependencies is here:

http://sage.math.washington.edu/home/was/patches/3502.hg

Attachments (2)

3502.hg (41.3 KB) - added by craigcitro 11 years ago.
William's bundle with all patches
trac-3502-addl.patch (34.3 KB) - added by craigcitro 11 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 11 years ago by was

  • Summary changed from modular symbols -- implement apply_sparse, which is needed for fast eigenvalue computation to [with patch; not ready for review] modular symbols -- implement apply_sparse, which is needed for fast eigenvalue computation

comment:2 Changed 11 years ago by was

  • Description modified (diff)
  • Summary changed from [with patch; not ready for review] modular symbols -- implement apply_sparse, which is needed for fast eigenvalue computation to [with patch; not ready for review] modular symbols -- optimize fast computation of hecke eigenvalues on weight 2 modular symbols for gamma0

comment:3 Changed 11 years ago by was

  • Description modified (diff)

comment:4 Changed 11 years ago by was

  • Description modified (diff)

comment:5 Changed 11 years ago by was

  • Description modified (diff)

comment:6 Changed 11 years ago by craigcitro

  • Milestone changed from sage-3.1.3 to sage-3.1.2
  • Summary changed from [with patch; not ready for review] modular symbols -- optimize fast computation of hecke eigenvalues on weight 2 modular symbols for gamma0 to [with positive review and additional patch, additional patch needs review] modular symbols -- optimize fast computation of hecke eigenvalues on weight 2 modular symbols for gamma0

So I looked over the code, and everything looks good. There were a handful of small touch-ups needed, missing doctests, etc., so I went ahead and took care of all of that. Someone should look over the additional patch I've posted, but after that, this looks ready to go.

I'm also cleaning up the ticket by deleting the 12 individual patches and posting William's complete bundle (from the URL he added above), and adding my patch.

Changed 11 years ago by craigcitro

William's bundle with all patches

Changed 11 years ago by craigcitro

comment:7 Changed 11 years ago by craigcitro

  • Milestone changed from sage-3.1.2 to sage-3.1.3

(This doesn't need to go into 3.1.2, so I'm moving it to 3.1.3.)

comment:8 Changed 11 years ago by was

  • Summary changed from [with positive review and additional patch, additional patch needs review] modular symbols -- optimize fast computation of hecke eigenvalues on weight 2 modular symbols for gamma0 to [with patch; positive review] modular symbols -- optimize fast computation of hecke eigenvalues on weight 2 modular symbols for gamma0

I read through the additional patch, applied it, doctested it, and I'm happy across the board. It's very good for increasing doctest coverage.

Thanks Craig!!

comment:9 Changed 11 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged 3502.hg and trac-3502-addl.patch in Sage 3.1.3.alpha1

Note: See TracTickets for help on using tickets.