Opened 13 years ago

Closed 13 years ago

#3470 closed enhancement (fixed)

[with spkg; positive review] add pyprocessing (=multiproccessing) to sage

Reported by: was Owned by: yi
Priority: major Milestone: sage-3.0.4
Component: dsage Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by dmharvey)

This has been officially accepted for Python 2.7, but we need it now. It is Python/c and takes literally 1 second to install, and supports OSX, Linux, Windows, etc.

See http://www.python.org/dev/peps/pep-0371/ for more details.

This is easily by far the best library I've ever used for making use of multicore machines. It's amazing.

Attachments (1)

processing-0.52.spkg (97.9 KB) - added by boothby 13 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 13 years ago by was

  • Description modified (diff)

Changed 13 years ago by boothby

comment:2 Changed 13 years ago by boothby

spkg contains spkg-check, SPKG.txt, hg repo. Works on debian/xeon. Needs testing on other platforms.

comment:3 Changed 13 years ago by gfurnish

Having looked at the source, I'm very worried about the lack of comments, but the design is solid. The socket io code is poor - its not very robust or fast compared to twisted. However, it "just works" as of now, and as long as it is hidden entirely behind the parallel api (so that we don't have any pyprocessing specific functions), I approve of this spkg from a code review perspective.

comment:4 Changed 13 years ago by yi

  • Summary changed from [with spkg; needs review] add pyprocessing (=multiproccessing) to sage to [with spkg; positive review] add pyprocessing (=multiproccessing) to sage

Looks good to me, pretty straightforward spkg. Also I'm not worried too much about the code since it will be included upstream in python 2.7 and it will have to adhere to Python's coding standards.

comment:5 Changed 13 years ago by dmharvey

  • Description modified (diff)

comment:6 Changed 13 years ago by was

Anyway, since every single person voted +1 and nobody voted -1 or
had issues, I declare this package officially accepted.

 -- William

comment:7 Changed 13 years ago by was

Nick wants the vote reopened for two more days, so I reopened it until Thursday.

comment:8 Changed 13 years ago by mabshoff

In the end the vote was positive and no one voted against it. It is nearly Thursday, so I am merging this. I did end up adding a .hgignore and check some more files into the repo. I also renamed the spkg pyprocessing-0.52.spkg. Additional positive review.

Cheers,

Michael

comment:9 Changed 13 years ago by mabshoff

  • Milestone changed from sage-3.1.1 to sage-3.0.4
  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.4.alpha1

Note: See TracTickets for help on using tickets.