Opened 4 months ago

Closed 3 months ago

#34228 closed enhancement (fixed)

tox -e docker-...-incremental

Reported by: Matthias Köppe Owned by:
Priority: critical Milestone: sage-9.8
Component: porting Keywords:
Cc: Dima Pasechnik, gh-kliem Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 85ce9a6 (Commits, GitHub, GitLab) Commit: 85ce9a666154ce6808bd76d60706f6a351ab269d
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

This does an incremental build of Sage on top of a prebuilt image published at ghcr.io (https://github.com/orgs/sagemath/packages?tab=packages)

For example:

$ tox -e docker-fedora-31-standard-incremental

Change History (22)

comment:1 Changed 4 months ago by Matthias Köppe

Branch: u/mkoeppe/tox__e_docker_____incremental

comment:2 Changed 4 months ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: Dima Pasechnik added
Commit: a9eaae57c9cf70c8bc0ed2968beb584906134927
Description: modified (diff)
Status: newneeds_review

New commits:

a9eaae5tox.ini, build/bin/write-dockerfile.sh: Add 'tox -e docker-...-incremental'

comment:3 Changed 4 months ago by git

Commit: a9eaae57c9cf70c8bc0ed2968beb584906134927b9bfbf9f0ae96f79d514cd665c46b182337dd711

Branch pushed to git repo; I updated commit sha1. New commits:

b9bfbf9tox.ini: Add comment

comment:4 Changed 4 months ago by git

Commit: b9bfbf9f0ae96f79d514cd665c46b182337dd7114c0d7f50b18f78ce561eccfc3a6c1196887dc226

Branch pushed to git repo; I updated commit sha1. New commits:

4c0d7f5tox.ini: Use FROM_DOCKER_REPOSITORY

comment:5 Changed 4 months ago by git

Commit: 4c0d7f50b18f78ce561eccfc3a6c1196887dc226a07874d2f2443785cc0a295d2d8989ab380d79d2

Branch pushed to git repo; I updated commit sha1. New commits:

a07874dbuild/bin/write-dockerfile.sh: In incremental build, keep logs

comment:6 Changed 4 months ago by Matthias Köppe

Ready for review

comment:7 Changed 4 months ago by git

Commit: a07874d2f2443785cc0a295d2d8989ab380d79d2ae269d17726a4ac6383b9645995d8c1f4c9b3f6d

Branch pushed to git repo; I updated commit sha1. New commits:

ae269d1tox.ini (docker-incremental): Do not include '-incremental' in the Docker image name

comment:8 Changed 4 months ago by Matthias Köppe

Status: needs_reviewneeds_work

does not work with devtoolset

comment:9 Changed 4 months ago by git

Commit: ae269d17726a4ac6383b9645995d8c1f4c9b3f6d5decadde7ae1985ab6a1b44fb52564972635f281

Branch pushed to git repo; I updated commit sha1. New commits:

b354a38tox.ini, .github/workflows/docker.yml: Reimplement -incremental via SKIP_SYSTEM_PACKAGES
5decaddbuild/bin/write-dockerfile.sh: Do not use persistent env var PACKAGES (except on nix)

comment:10 Changed 4 months ago by Matthias Köppe

Status: needs_workneeds_review

comment:11 Changed 4 months ago by Matthias Köppe

Cc: gh-kliem added

comment:12 Changed 4 months ago by git

Commit: 5decadde7ae1985ab6a1b44fb52564972635f281a90608f7ac6cd3a63ada3ae939ec4b316a902639

Branch pushed to git repo; I updated commit sha1. New commits:

adddf8eMerge tag '9.7.beta8' into t/34228/tox__e_docker_____incremental
a90608fbuild/bin/write-dockerfile.sh: Invoke sage-package directly, do not go through ./sage

comment:13 Changed 3 months ago by git

Commit: a90608f7ac6cd3a63ada3ae939ec4b316a90263985ce9a666154ce6808bd76d60706f6a351ab269d

Branch pushed to git repo; I updated commit sha1. New commits:

85ce9a6Merge tag '9.7.rc0' into t/34228/tox__e_docker_____incremental

comment:14 Changed 3 months ago by Matthias Köppe

Let's get this in please

comment:15 Changed 3 months ago by Matthias Köppe

ping

comment:16 Changed 3 months ago by Dima Pasechnik

sorry, can't review, docker issues on one machine I have it.

(hilariosly, another laptop, with macOS, has docker just fine, but it's misplaced somewhere in our messy house, hopefully I'll bump into it soon...)

Last edited 3 months ago by Dima Pasechnik (previous) (diff)

comment:18 Changed 3 months ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

lgtm

comment:19 Changed 3 months ago by Matthias Köppe

Thank you!

comment:20 Changed 3 months ago by Matthias Köppe

Priority: majorcritical

Marking it as critical because a long chain of tickets depends on it

comment:21 Changed 3 months ago by Matthias Köppe

Milestone: sage-9.7sage-9.8

comment:22 Changed 3 months ago by Volker Braun

Branch: u/mkoeppe/tox__e_docker_____incremental85ce9a666154ce6808bd76d60706f6a351ab269d
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.