Opened 5 months ago

Closed 2 months ago

#34212 closed enhancement (fixed)

`log_embedding` for number field elements

Reported by: Jing Guo Owned by:
Priority: trivial Milestone: sage-9.8
Component: number fields Keywords: gsoc2022
Cc: Ben Hutz, Alexander Galarraga Merged in:
Authors: Jing Guo Reviewers: Alexander Galarraga
Report Upstream: N/A Work issues:
Branch: 03aabf5 (Commits, GitHub, GitLab) Commit: 03aabf5ae70f298d5e99c4b0a5a3f2452c0f3d45
Dependencies: Stopgaps:

Status badges

Description (last modified by Jing Guo)

This ticket is to add log_embedding (logarithmic embedding) functionality for number field elements, which is then used in #32686 for implementing points_of_bounded_height.

Change History (24)

comment:1 Changed 5 months ago by Jing Guo

Branch: u/gh-guojing0/34212_logmap
Commit: 41849f8f8bde2c13e82cf9ca0824e4d4ec1019cc
Description: modified (diff)
Status: newneeds_review
Summary: `log_map` for number field elements`log_embedding` for number field elements

New commits:

460d5f534212: log embedding for number field elements
41849f834212: tests and docs

comment:2 Changed 4 months ago by git

Commit: 41849f8f8bde2c13e82cf9ca0824e4d4ec1019cc629145f1ec401d09727278ba9871db33678156f9

Branch pushed to git repo; I updated commit sha1. New commits:

8cf8e2134212: Remove log embedding from number_field_element.pyx
6a0a90c34212: log embedding in number_field.py
629145f34212: fix doc

comment:3 Changed 4 months ago by git

Commit: 629145f1ec401d09727278ba9871db33678156f96cb6ac86c006de0dc2adb9e33d30a06e41ca472e

Branch pushed to git repo; I updated commit sha1. New commits:

6cb6ac834212: remove unused import

comment:4 Changed 4 months ago by git

Commit: 6cb6ac86c006de0dc2adb9e33d30a06e41ca472e650dd045cb4a10bb623e6ac517291e7dcc172095

Branch pushed to git repo; I updated commit sha1. New commits:

650dd0434212: log embedding as a morphism

comment:5 Changed 4 months ago by Matthias Köppe

The new methods are not indented correctly, so this cannot build

comment:6 Changed 4 months ago by git

Commit: 650dd045cb4a10bb623e6ac517291e7dcc17209535d369ccbd927051c31b672ba1426cd0c4caab9d

Branch pushed to git repo; I updated commit sha1. New commits:

35d369c34212: fix doc

comment:7 Changed 4 months ago by git

Commit: 35d369ccbd927051c31b672ba1426cd0c4caab9d77c4a98df8c1e3d48609b9b7030613c5d9099b1c

Branch pushed to git repo; I updated commit sha1. New commits:

77c4a9834212 fix doc

comment:8 Changed 4 months ago by git

Commit: 77c4a98df8c1e3d48609b9b7030613c5d9099b1c76ba3fe26c67005dfd5ee02cd88ef4cec9008c6e

Branch pushed to git repo; I updated commit sha1. New commits:

76ba3fefix

comment:9 Changed 4 months ago by git

Commit: 76ba3fe26c67005dfd5ee02cd88ef4cec9008c6ea03b6ac817c07d80aac1af4868f10a3a7a24fd64

Branch pushed to git repo; I updated commit sha1. New commits:

a03b6acfix

comment:10 Changed 4 months ago by git

Commit: a03b6ac817c07d80aac1af4868f10a3a7a24fd64baed2b1083f551f3b3c74ae801efb60a9c3cef4e

Branch pushed to git repo; I updated commit sha1. New commits:

baed2b1fix

comment:11 Changed 4 months ago by git

Commit: baed2b1083f551f3b3c74ae801efb60a9c3cef4e71b6f4770ca168289c015d6e172ac8562159ab47

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

570fb63clean-up two files in quadratic forms
2065e01fix another detail in quad. forms
7230bd1Updated SageMath version to 9.7.beta5
71b6f4734212: log embedding for number field

comment:12 Changed 4 months ago by Jing Guo

Branch: u/gh-guojing0/34212_logmapu/gh-guojing0/34212
Commit: 71b6f4770ca168289c015d6e172ac8562159ab479bb1d9ba553f10139bc3ae94f99d225d6b0ad201

Since there are too many commits on this branch, so I created a new one.


New commits:

9bb1d9b34212: log embedding for number fields

comment:13 Changed 4 months ago by Jing Guo

Branch: u/gh-guojing0/34212u/gh-guojing0/34212_stable
Commit: 9bb1d9ba553f10139bc3ae94f99d225d6b0ad2010462be9a9c9a87d498e7ea956ff9b9ed23b43339

New commits:

0462be934212: log embedding for number fields

comment:14 Changed 4 months ago by git

Commit: 0462be9a9c9a87d498e7ea956ff9b9ed23b43339d086479da51147e7a539ea55f5d3225dd704561a

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d08647934212: clean version

comment:15 Changed 4 months ago by git

Commit: d086479da51147e7a539ea55f5d3225dd704561aba8c658fb0abc2244d935923e3939b16d8f54435

Branch pushed to git repo; I updated commit sha1. New commits:

2e9c42a34212: fix doc
ba8c65834212: fix doc and code

comment:16 Changed 3 months ago by Alexander Galarraga

Status: needs_reviewneeds_work

Two comments:

  • Docbuild fails as [Cohen1993] isn't the reference, it should be [Coh1993].
  • I'd like to see an example with more than two places. One option would be to add the number field defined by x4 - 8x2 + 3, which has four real places, as an example.
Last edited 3 months ago by Alexander Galarraga (previous) (diff)

comment:17 Changed 3 months ago by git

Commit: ba8c658fb0abc2244d935923e3939b16d8f544356fb2387679f2b8279d3f6e6d1c871a0a42cde1de

Branch pushed to git repo; I updated commit sha1. New commits:

f531b9334212: Correct doc and add an example
6fb238734212: log embedding for relative number field

comment:18 Changed 3 months ago by git

Commit: 6fb2387679f2b8279d3f6e6d1c871a0a42cde1de03aabf5ae70f298d5e99c4b0a5a3f2452c0f3d45

Branch pushed to git repo; I updated commit sha1. New commits:

03aabf534212: correct examples

comment:19 Changed 3 months ago by Jing Guo

Status: needs_workneeds_review

Thank you, Alex. Log embedding for the relative number field is also supported now.

comment:20 Changed 3 months ago by Alexander Galarraga

Status: needs_reviewpositive_review

comment:21 Changed 3 months ago by Matthias Köppe

reviewer name

comment:22 Changed 3 months ago by Alexander Galarraga

Reviewers: Alexander Galarraga

comment:23 Changed 3 months ago by Matthias Köppe

Milestone: sage-9.7sage-9.8

comment:24 Changed 2 months ago by Volker Braun

Branch: u/gh-guojing0/34212_stable03aabf5ae70f298d5e99c4b0a5a3f2452c0f3d45
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.