Opened 5 months ago
Closed 2 months ago
#34212 closed enhancement (fixed)
`log_embedding` for number field elements
Reported by:  Jing Guo  Owned by:  

Priority:  trivial  Milestone:  sage9.8 
Component:  number fields  Keywords:  gsoc2022 
Cc:  Ben Hutz, Alexander Galarraga  Merged in:  
Authors:  Jing Guo  Reviewers:  Alexander Galarraga 
Report Upstream:  N/A  Work issues:  
Branch:  03aabf5 (Commits, GitHub, GitLab)  Commit:  03aabf5ae70f298d5e99c4b0a5a3f2452c0f3d45 
Dependencies:  Stopgaps: 
Description (last modified by )
This ticket is to add log_embedding
(logarithmic embedding) functionality for number field elements, which is then used in #32686 for implementing points_of_bounded_height
.
Change History (24)
comment:1 Changed 5 months ago by
Branch:  → u/ghguojing0/34212_logmap 

Commit:  → 41849f8f8bde2c13e82cf9ca0824e4d4ec1019cc 
Description:  modified (diff) 
Status:  new → needs_review 
Summary:  `log_map` for number field elements → `log_embedding` for number field elements 
comment:2 Changed 4 months ago by
Commit:  41849f8f8bde2c13e82cf9ca0824e4d4ec1019cc → 629145f1ec401d09727278ba9871db33678156f9 

comment:3 Changed 4 months ago by
Commit:  629145f1ec401d09727278ba9871db33678156f9 → 6cb6ac86c006de0dc2adb9e33d30a06e41ca472e 

Branch pushed to git repo; I updated commit sha1. New commits:
6cb6ac8  34212: remove unused import

comment:4 Changed 4 months ago by
Commit:  6cb6ac86c006de0dc2adb9e33d30a06e41ca472e → 650dd045cb4a10bb623e6ac517291e7dcc172095 

Branch pushed to git repo; I updated commit sha1. New commits:
650dd04  34212: log embedding as a morphism

comment:6 Changed 4 months ago by
Commit:  650dd045cb4a10bb623e6ac517291e7dcc172095 → 35d369ccbd927051c31b672ba1426cd0c4caab9d 

Branch pushed to git repo; I updated commit sha1. New commits:
35d369c  34212: fix doc

comment:7 Changed 4 months ago by
Commit:  35d369ccbd927051c31b672ba1426cd0c4caab9d → 77c4a98df8c1e3d48609b9b7030613c5d9099b1c 

Branch pushed to git repo; I updated commit sha1. New commits:
77c4a98  34212 fix doc

comment:8 Changed 4 months ago by
Commit:  77c4a98df8c1e3d48609b9b7030613c5d9099b1c → 76ba3fe26c67005dfd5ee02cd88ef4cec9008c6e 

Branch pushed to git repo; I updated commit sha1. New commits:
76ba3fe  fix

comment:9 Changed 4 months ago by
Commit:  76ba3fe26c67005dfd5ee02cd88ef4cec9008c6e → a03b6ac817c07d80aac1af4868f10a3a7a24fd64 

Branch pushed to git repo; I updated commit sha1. New commits:
a03b6ac  fix

comment:10 Changed 4 months ago by
Commit:  a03b6ac817c07d80aac1af4868f10a3a7a24fd64 → baed2b1083f551f3b3c74ae801efb60a9c3cef4e 

Branch pushed to git repo; I updated commit sha1. New commits:
baed2b1  fix

comment:11 Changed 4 months ago by
Commit:  baed2b1083f551f3b3c74ae801efb60a9c3cef4e → 71b6f4770ca168289c015d6e172ac8562159ab47 

comment:12 Changed 4 months ago by
Branch:  u/ghguojing0/34212_logmap → u/ghguojing0/34212 

Commit:  71b6f4770ca168289c015d6e172ac8562159ab47 → 9bb1d9ba553f10139bc3ae94f99d225d6b0ad201 
Since there are too many commits on this branch, so I created a new one.
New commits:
9bb1d9b  34212: log embedding for number fields

comment:13 Changed 4 months ago by
Branch:  u/ghguojing0/34212 → u/ghguojing0/34212_stable 

Commit:  9bb1d9ba553f10139bc3ae94f99d225d6b0ad201 → 0462be9a9c9a87d498e7ea956ff9b9ed23b43339 
New commits:
0462be9  34212: log embedding for number fields

comment:14 Changed 4 months ago by
Commit:  0462be9a9c9a87d498e7ea956ff9b9ed23b43339 → d086479da51147e7a539ea55f5d3225dd704561a 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
d086479  34212: clean version

comment:15 Changed 4 months ago by
Commit:  d086479da51147e7a539ea55f5d3225dd704561a → ba8c658fb0abc2244d935923e3939b16d8f54435 

comment:16 Changed 3 months ago by
Status:  needs_review → needs_work 

Two comments:
 Docbuild fails as [Cohen1993] isn't the reference, it should be [Coh1993].
 I'd like to see an example with more than two places. One option would be to add the number field defined by x^{4}  8x^{2} + 3, which has four real places, as an example.
comment:17 Changed 3 months ago by
Commit:  ba8c658fb0abc2244d935923e3939b16d8f54435 → 6fb2387679f2b8279d3f6e6d1c871a0a42cde1de 

comment:18 Changed 3 months ago by
Commit:  6fb2387679f2b8279d3f6e6d1c871a0a42cde1de → 03aabf5ae70f298d5e99c4b0a5a3f2452c0f3d45 

Branch pushed to git repo; I updated commit sha1. New commits:
03aabf5  34212: correct examples

comment:19 Changed 3 months ago by
Status:  needs_work → needs_review 

Thank you, Alex. Log embedding for the relative number field is also supported now.
comment:20 Changed 3 months ago by
Status:  needs_review → positive_review 

comment:22 Changed 3 months ago by
Reviewers:  → Alexander Galarraga 

comment:23 Changed 3 months ago by
Milestone:  sage9.7 → sage9.8 

comment:24 Changed 2 months ago by
Branch:  u/ghguojing0/34212_stable → 03aabf5ae70f298d5e99c4b0a5a3f2452c0f3d45 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
34212: log embedding for number field elements
34212: tests and docs