Opened 10 years ago

Closed 10 years ago

Last modified 9 years ago

#3418 closed defect (fixed)

[with patch, positive review] added new combinatorial functions for tableaux and crystals

Reported by: aschilling Owned by: Mike Hansen
Priority: minor Milestone: sage-3.0.3
Component: combinatorics Keywords: promotion; reflection
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

I added a two new functions promotion and promotion_inverse for rectangular tableaux.

I also added a reflection operator for the crystal library.

Attachments (2)

promotion_reflection_for_trac.patch (3.0 KB) - added by aschilling 10 years ago.
promotion_reflection-3418-submitted.patch (3.1 KB) - added by aschilling 10 years ago.
fixed the issues that Mike raised

Download all attachments as: .zip

Change History (10)

Changed 10 years ago by aschilling

comment:1 Changed 10 years ago by mhansen

  • Summary changed from added new combinatorial functions for tableaux and crystals to [with patch, needs review] added new combinatorial functions for tableaux and crystals

comment:2 Changed 10 years ago by mhansen

Hi Anne,

The one thing I would change is that instead of returning the string "Tableaux is not rectangular" is raising a ValueError? with that message. Also, could you add a line before "EXAMPLES" in "def s("?

Other than that, it looks good to go in.

--Mike

comment:3 Changed 10 years ago by mhansen

Oh, the doctest for the ValueError? would look something like this:

sage: t = Tableau([[1,2],[2]]) 
sage: t.promotion(3) 
Traceback (most recent call last):
...
ValueError: Tableaux is not recutangular

Changed 10 years ago by aschilling

fixed the issues that Mike raised

comment:4 Changed 10 years ago by mhansen

  • Summary changed from [with patch, needs review] added new combinatorial functions for tableaux and crystals to [with patch, positive review] added new combinatorial functions for tableaux and crystals

comment:5 Changed 10 years ago by mabshoff

  • Milestone changed from sage-combinat to sage-3.0.4

comment:6 Changed 10 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged promotion_reflection-3418-submitted.patch in Sage 3.0.3.rc0

comment:7 Changed 10 years ago by mabshoff

  • Milestone changed from sage-3.0.4 to sage-3.0.3

comment:8 Changed 9 years ago by nthiery

  • Cc sage-combinat added
Note: See TracTickets for help on using tickets.