Opened 5 months ago
Closed 3 months ago
#34118 closed enhancement (fixed)
Update sympy to 1.11.1
Reported by:  Matthias Köppe  Owned by:  

Priority:  major  Milestone:  sage9.8 
Component:  packages: standard  Keywords:  
Cc:  François Bissey, Oscar Benjamin, Antonio Rojas, Dave Morris  Merged in:  
Authors:  Oscar Benjamin, Matthias Koeppe  Reviewers:  Matthias Koeppe, Antonio Rojas, Eric Gourgoulhon 
Report Upstream:  N/A  Work issues:  
Branch:  5281574 (Commits, GitHub, GitLab)  Commit:  52815744bde2b682245b6f985a112f7cb8666056 
Dependencies:  Stopgaps: 
Description (last modified by )
SymPy 1.11 was released on 20220823. https://github.com/sympy/sympy/wiki/releasenotesfor1.11
This ticket also serves as the target of SymPy's cisage workflow after https://github.com/sympy/sympy/pull/23728
Change History (26)
comment:1 Changed 5 months ago by
Branch:  → u/mkoeppe/sympy_1_11 

comment:2 Changed 5 months ago by
Commit:  → 08dc8fd8be08f0b3a6e74a73b4769c3bf066c0f5 

Dependencies:  → #34017, #34088 
Description:  modified (diff) 
comment:3 Changed 5 months ago by
Cc:  François Bissey added 

comment:4 Changed 5 months ago by
Description:  modified (diff) 

comment:5 Changed 5 months ago by
Current failures: see https://github.com/sympy/sympy/pull/23728#issuecomment1176231090
comment:6 Changed 5 months ago by
Cc:  Oscar Benjamin added 

Summary:  sympy 1.11 → Update sympy to 1.11 
comment:7 Changed 5 months ago by
Branch:  u/mkoeppe/sympy_1_11 → u/ghoscarbenjamin/sympy_1_11 

comment:8 Changed 5 months ago by
Authors:  → Oscar Benjamin 

Commit:  08dc8fd8be08f0b3a6e74a73b4769c3bf066c0f5 → 04d0344c9509cf247c1d154b443c0a354d05e417 
Dependencies:  #34017, #34088 
New commits:
04d0344  Update doctests for SymPy 1.11

comment:9 Changed 3 months ago by
Branch:  u/ghoscarbenjamin/sympy_1_11 → u/mkoeppe/sympy_1_11 

comment:10 Changed 3 months ago by
Authors:  Oscar Benjamin → Oscar Benjamin, Matthias Koeppe 

Commit:  04d0344c9509cf247c1d154b443c0a354d05e417 → a6ab4fa9612171c8e53fa8b24f01c0f1ce52e477 
Milestone:  sagepending → sage9.7 
New commits:
a6ab4fa  build/pkgs/sympy: Update to 1.11

comment:11 Changed 3 months ago by
Description:  modified (diff) 

comment:12 Changed 3 months ago by
Commit:  a6ab4fa9612171c8e53fa8b24f01c0f1ce52e477 → 16fdc52e7dee6414a36cf3e6546b4a7c9089b21d 

comment:13 Changed 3 months ago by
Status:  new → needs_review 

comment:14 Changed 3 months ago by
Reviewers:  → Matthias Koeppe, ... 

comment:15 Changed 3 months ago by
Cc:  Antonio Rojas Dave Morris added 

comment:16 Changed 3 months ago by
I don't see any problems with the upgrade, but I am concerned that sympy is core functionality in symbolics so I wonder if this is too late in the release cycle for adequate testing?
The automated systems do not seem to have successfully tested the ticket. (Do they not have enabledownloadfromupstreamurl
?) So I ran make testlong
on CoCalc (Ubuntu 20.04) and got only two errors, which I think are known, and have nothing to do with this ticket:
sage t long warnlong 81.9 randomseed=241846751556032050884921104136244529069 src/sage/interfaces/expect.py ********************************************************************** File "src/sage/interfaces/expect.py", line 937, in sage.interfaces.expect.Expect._eval_line Failed example: singular.interrupt() Expected: True Got: False ********************************************************************** File "src/sage/interfaces/expect.py", line 943, in sage.interfaces.expect.Expect._eval_line Failed example: singular('2+3') Expected: Singular crashed  automatically restarting. 5 Got: 5
comment:17 Changed 3 months ago by
Reviewers:  Matthias Koeppe, ... → Matthias Koeppe, Antonio Rojas 

Status:  needs_review → positive_review 
WFM
comment:18 Changed 3 months ago by
I'm planning a SymPy? 1.11.1 release imminently after this: https://github.com/sympy/sympy/pull/23976
I don't know if that affects SAGE but you might want to hold off until that gets released.
comment:19 Changed 3 months ago by
Status:  positive_review → needs_work 

comment:20 Changed 3 months ago by
Commit:  16fdc52e7dee6414a36cf3e6546b4a7c9089b21d → 52815744bde2b682245b6f985a112f7cb8666056 

comment:21 Changed 3 months ago by
Status:  needs_work → needs_review 

Summary:  Update sympy to 1.11 → Update sympy to 1.11.1 
comment:23 Changed 3 months ago by
Reviewers:  Matthias Koeppe, Antonio Rojas → Matthias Koeppe, Antonio Rojas, Eric Gourgoulhon 

Status:  needs_review → positive_review 
LGTM.
comment:25 Changed 3 months ago by
Milestone:  sage9.7 → sage9.8 

comment:26 Changed 3 months ago by
Branch:  u/mkoeppe/sympy_1_11 → 52815744bde2b682245b6f985a112f7cb8666056 

Resolution:  → fixed 
Status:  positive_review → closed 
New commits:
build/bin/writedockerfile.sh: ADD src/VERSION.txt
Merge #34017
build/pkgs/python3/distros/cygwin.txt: Add packages needed for ensurepip
Merge #34088