Opened 5 months ago

Closed 3 months ago

#34118 closed enhancement (fixed)

Update sympy to 1.11.1

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.8
Component: packages: standard Keywords:
Cc: François Bissey, Oscar Benjamin, Antonio Rojas, Dave Morris Merged in:
Authors: Oscar Benjamin, Matthias Koeppe Reviewers: Matthias Koeppe, Antonio Rojas, Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: 5281574 (Commits, GitHub, GitLab) Commit: 52815744bde2b682245b6f985a112f7cb8666056
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

SymPy 1.11 was released on 2022-08-23. https://github.com/sympy/sympy/wiki/release-notes-for-1.11

This ticket also serves as the target of SymPy's ci-sage workflow after https://github.com/sympy/sympy/pull/23728

Change History (26)

comment:1 Changed 5 months ago by Matthias Köppe

Branch: u/mkoeppe/sympy_1_11

comment:2 Changed 5 months ago by Matthias Köppe

Commit: 08dc8fd8be08f0b3a6e74a73b4769c3bf066c0f5
Dependencies: #34017, #34088
Description: modified (diff)

New commits:

58d62f4build/bin/write-dockerfile.sh: ADD src/VERSION.txt
8ed04b9Merge #34017
d835afcbuild/pkgs/python3/distros/cygwin.txt: Add packages needed for ensurepip
08dc8fdMerge #34088

comment:3 Changed 5 months ago by François Bissey

Cc: François Bissey added

comment:4 Changed 5 months ago by Matthias Köppe

Description: modified (diff)

comment:6 Changed 5 months ago by Matthias Köppe

Cc: Oscar Benjamin added
Summary: sympy 1.11Update sympy to 1.11

comment:7 Changed 5 months ago by Oscar Benjamin

Branch: u/mkoeppe/sympy_1_11u/gh-oscarbenjamin/sympy_1_11

comment:8 Changed 5 months ago by Matthias Köppe

Authors: Oscar Benjamin
Commit: 08dc8fd8be08f0b3a6e74a73b4769c3bf066c0f504d0344c9509cf247c1d154b443c0a354d05e417
Dependencies: #34017, #34088

New commits:

04d0344Update doctests for SymPy 1.11

comment:9 Changed 3 months ago by Matthias Köppe

Branch: u/gh-oscarbenjamin/sympy_1_11u/mkoeppe/sympy_1_11

comment:10 Changed 3 months ago by Matthias Köppe

Authors: Oscar BenjaminOscar Benjamin, Matthias Koeppe
Commit: 04d0344c9509cf247c1d154b443c0a354d05e417a6ab4fa9612171c8e53fa8b24f01c0f1ce52e477
Milestone: sage-pendingsage-9.7

New commits:

a6ab4fabuild/pkgs/sympy: Update to 1.11

comment:11 Changed 3 months ago by Matthias Köppe

Description: modified (diff)

comment:12 Changed 3 months ago by git

Commit: a6ab4fa9612171c8e53fa8b24f01c0f1ce52e47716fdc52e7dee6414a36cf3e6546b4a7c9089b21d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5db5d4eUpdate doctests for SymPy 1.11
16fdc52build/pkgs/sympy: Update to 1.11

comment:13 Changed 3 months ago by Matthias Köppe

Status: newneeds_review

comment:14 Changed 3 months ago by Matthias Köppe

Reviewers: Matthias Koeppe, ...

comment:15 Changed 3 months ago by Matthias Köppe

Cc: Antonio Rojas Dave Morris added

comment:16 Changed 3 months ago by Dave Morris

I don't see any problems with the upgrade, but I am concerned that sympy is core functionality in symbolics so I wonder if this is too late in the release cycle for adequate testing?

The automated systems do not seem to have successfully tested the ticket. (Do they not have --enable-download-from-upstream-url?) So I ran make testlong on CoCalc (Ubuntu 20.04) and got only two errors, which I think are known, and have nothing to do with this ticket:

sage -t --long --warn-long 81.9 --random-seed=241846751556032050884921104136244529069 src/sage/interfaces/expect.py
**********************************************************************
File "src/sage/interfaces/expect.py", line 937, in sage.interfaces.expect.Expect._eval_line
Failed example:
    singular.interrupt()
Expected:
    True
Got:
    False
**********************************************************************
File "src/sage/interfaces/expect.py", line 943, in sage.interfaces.expect.Expect._eval_line
Failed example:
    singular('2+3')
Expected:
    Singular crashed -- automatically restarting.
    5
Got:
    5

comment:17 Changed 3 months ago by Antonio Rojas

Reviewers: Matthias Koeppe, ...Matthias Koeppe, Antonio Rojas
Status: needs_reviewpositive_review

WFM

comment:18 Changed 3 months ago by Oscar Benjamin

I'm planning a SymPy? 1.11.1 release imminently after this: https://github.com/sympy/sympy/pull/23976

I don't know if that affects SAGE but you might want to hold off until that gets released.

comment:19 Changed 3 months ago by Matthias Köppe

Status: positive_reviewneeds_work

comment:20 Changed 3 months ago by git

Commit: 16fdc52e7dee6414a36cf3e6546b4a7c9089b21d52815744bde2b682245b6f985a112f7cb8666056

Branch pushed to git repo; I updated commit sha1. New commits:

be00aceMerge tag '9.7.rc0' into t/34118/sympy_1_11
5281574build/pkgs/sympy: Update to 1.11.1

comment:21 Changed 3 months ago by Matthias Köppe

Status: needs_workneeds_review
Summary: Update sympy to 1.11Update sympy to 1.11.1

comment:22 Changed 3 months ago by Matthias Köppe

Let's get this in please.

comment:23 Changed 3 months ago by Eric Gourgoulhon

Reviewers: Matthias Koeppe, Antonio RojasMatthias Koeppe, Antonio Rojas, Eric Gourgoulhon
Status: needs_reviewpositive_review

LGTM.

comment:24 Changed 3 months ago by Matthias Köppe

Thanks!

comment:25 Changed 3 months ago by Matthias Köppe

Milestone: sage-9.7sage-9.8

comment:26 Changed 3 months ago by Volker Braun

Branch: u/mkoeppe/sympy_1_1152815744bde2b682245b6f985a112f7cb8666056
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.